From 61929821eb8397a1982dfd48c09494b4b83613e7 Mon Sep 17 00:00:00 2001
From: d-m-u <drewuhlmann@gmail.com>
Date: Tue, 7 Aug 2018 10:11:05 -0400
Subject: [PATCH] Set checkbox on load, sans default, to be false, not nil

---
 app/models/dialog_field_check_box.rb       |  8 ++++-
 spec/models/dialog_field_check_box_spec.rb | 39 ++++++++++++++++++++--
 2 files changed, 44 insertions(+), 3 deletions(-)

diff --git a/app/models/dialog_field_check_box.rb b/app/models/dialog_field_check_box.rb
index d73abc63a70..964ff70a78a 100644
--- a/app/models/dialog_field_check_box.rb
+++ b/app/models/dialog_field_check_box.rb
@@ -5,8 +5,14 @@ def checked?
     value == "t"
   end
 
+  def initialize_value_context
+    if @value.blank?
+      @value = dynamic ? values_from_automate : default_value.presence || initial_values
+    end
+  end
+
   def initial_values
-    false
+    'f'
   end
 
   def script_error_values
diff --git a/spec/models/dialog_field_check_box_spec.rb b/spec/models/dialog_field_check_box_spec.rb
index 281f66bc4f7..da0f81e4bcc 100644
--- a/spec/models/dialog_field_check_box_spec.rb
+++ b/spec/models/dialog_field_check_box_spec.rb
@@ -19,11 +19,46 @@
     end
   end
 
+  describe "#initialize_value_context" do
+    context "dynamic" do
+      let(:dialog_field) { described_class.new(:dynamic => true) }
+      before do
+        allow(DynamicDialogFieldValueProcessor).to receive(:values_from_automate).with(dialog_field).and_return("f")
+      end
+
+      it "returns automate vals" do
+        dialog_field.initialize_value_context
+
+        expect(dialog_field.value).to eq('f')
+      end
+    end
+
+    context "not dynamic" do
+      context "with default" do
+        let(:dialog_field) { described_class.new(:default_value => "t") }
+        it "returns default" do
+          dialog_field.initialize_value_context
+
+          expect(dialog_field.value).to eq('t')
+        end
+      end
+
+      context "without default" do
+        let(:dialog_field) { described_class.new(:default_value => nil) }
+        it "returns initial vals" do
+          dialog_field.initialize_value_context
+
+          expect(dialog_field.value).to eq('f')
+        end
+      end
+    end
+  end
+
   describe "#initial_values" do
     let(:dialog_field) { described_class.new }
 
     it "returns false" do
-      expect(dialog_field.initial_values).to be_falsey
+      expect(dialog_field.initial_values).to eq('f')
     end
   end
 
@@ -85,7 +120,7 @@
       end
 
       it "returns the initial values" do
-        expect(dialog_field.normalize_automate_values(automate_hash)).to eq(false)
+        expect(dialog_field.normalize_automate_values(automate_hash)).to eq('f')
       end
     end
   end