From 7be7595d7c0da12299aeeb16226f2502ed82dd5e Mon Sep 17 00:00:00 2001 From: Zita Nemeckova Date: Thu, 19 Sep 2019 14:16:22 +0200 Subject: [PATCH 1/2] Fix missing name of deleted GOD Button/ButtonGroup Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1744478 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1753289 --- .../generic_object/generic-object-definition-toolbar.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/components/generic_object/generic-object-definition-toolbar.js b/app/assets/javascripts/components/generic_object/generic-object-definition-toolbar.js index 510d5aa2b22..cd2bd648873 100644 --- a/app/assets/javascripts/components/generic_object/generic-object-definition-toolbar.js +++ b/app/assets/javascripts/components/generic_object/generic-object-definition-toolbar.js @@ -70,8 +70,8 @@ function genericObjectDefinitionToolbarController(API, miqService, $window) { .catch(miqService.handleFailure); } - function postAction(response) { - var entityName = response.name; + function postAction() { + var entityName = toolbar.entityName; var saveMsg = sprintf(__('%s:"%s" was successfully deleted'), toolbar.entity, entityName); if (toolbar.redirectUrl) { miqService.redirectBack(saveMsg, 'success', toolbar.redirectUrl); From abbddddf7d6ba28909f6b9847ee20ab2125c3a11 Mon Sep 17 00:00:00 2001 From: Zita Nemeckova Date: Wed, 25 Sep 2019 12:57:27 +0200 Subject: [PATCH 2/2] Add a space behind the semicolon to make this typographically correct --- .../generic_object/generic-object-definition-toolbar.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/javascripts/components/generic_object/generic-object-definition-toolbar.js b/app/assets/javascripts/components/generic_object/generic-object-definition-toolbar.js index cd2bd648873..4048a6ecbdd 100644 --- a/app/assets/javascripts/components/generic_object/generic-object-definition-toolbar.js +++ b/app/assets/javascripts/components/generic_object/generic-object-definition-toolbar.js @@ -72,7 +72,7 @@ function genericObjectDefinitionToolbarController(API, miqService, $window) { function postAction() { var entityName = toolbar.entityName; - var saveMsg = sprintf(__('%s:"%s" was successfully deleted'), toolbar.entity, entityName); + var saveMsg = sprintf(__('%s: "%s" was successfully deleted'), toolbar.entity, entityName); if (toolbar.redirectUrl) { miqService.redirectBack(saveMsg, 'success', toolbar.redirectUrl); } else {