From fd80afa47a39a574e5d195c490d51ee754e6f18a Mon Sep 17 00:00:00 2001 From: Zita Nemeckova Date: Tue, 18 Dec 2018 10:47:29 +0100 Subject: [PATCH 1/2] Use onchange only for radio buttons Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656003 --- app/assets/javascripts/miq_ujs_bindings.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/javascripts/miq_ujs_bindings.js b/app/assets/javascripts/miq_ujs_bindings.js index 02d3ee3043e..39adbf550fa 100644 --- a/app/assets/javascripts/miq_ujs_bindings.js +++ b/app/assets/javascripts/miq_ujs_bindings.js @@ -139,7 +139,7 @@ $(document).ready(function() { }); // Firefox on MacOs isn't firing onfocus events for radio buttons so onchange is used instead - $(document).on('change', '[data-miq_observe]', function() { + $(document).on('change', '[data-miq_observe][type="radio"]', function() { var el = $(this); var parms = $.parseJSON(el.attr('data-miq_observe')); var id = el.attr('id'); From f72005ac7440c395067a06d534a325a6a872d6b8 Mon Sep 17 00:00:00 2001 From: Zita Nemeckova Date: Tue, 18 Dec 2018 13:47:39 +0100 Subject: [PATCH 2/2] Disable onfocus for radio buttons --- app/assets/javascripts/miq_ujs_bindings.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/assets/javascripts/miq_ujs_bindings.js b/app/assets/javascripts/miq_ujs_bindings.js index 39adbf550fa..8b3857bfa69 100644 --- a/app/assets/javascripts/miq_ujs_bindings.js +++ b/app/assets/javascripts/miq_ujs_bindings.js @@ -111,6 +111,9 @@ $(document).ready(function() { }; var observeOnChange = function(el, parms) { + if (el.prop("type") === "radio") { + return; + } // No interval passed, use event observer el.off('change'); el.on('change', _.debounce(function() {