New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop I18n.t used for overriding URLs #6083

Closed

himdel opened this issue Aug 22, 2019 · 1 comment · Fixed by #6718

Assignees

Labels

internationalization technical debt

Contributor

himdel commented Aug 22, 2019

app/views/support/show.html.haml
24:          %a{:href => I18n.t("product.support_website").html_safe, :target => "_new"}
25:            = I18n.t("product.support_website_text").html_safe

app/presenters/menu/default_menu.rb
272:            :title => I18n.t('product.support_website_text'),
273:            :href  => I18n.t("product.support_website").html_safe

We should replace this by the mechanism introduced by @mzazrivec in #6077, instead of (ab)using i18n.t :)

The text was updated successfully, but these errors were encountered:

mzazrivec added the bug label

chessbyte assigned mzazrivec

Member

chessbyte commented Feb 21, 2020 •

edited

Loading

@mzazrivec if this is still an issue, would you please make a PR to address.

chessbyte added technical debt internationalization and removed bug labels

mzazrivec mentioned this issue

Use product settings for docs & links #6718

Merged

chessbyte closed this as completed in #6718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment