Infinite spinner when clicking on configuration provider

[hstastna]

There is an issue in Configuration > Management > Providers accordion: never ending infinite spinner occurs when clicking on a provider from the list.

Additional info:

• no need to be on root node to reproduce the issue
• just found only in master, it works on gaprindashvili branch
• after refreshing the page, we return to the list of providers
• no error in log

Actual result: (nothing but infinite spinner)

Expected result: (configuration profiles under the provider should be displayed)

[himdel]

The js errror:

TypeError: itemId.indexOf is not a function
    at ReportDataController.onItemClicked (http://localhost:3000/assets/controllers/report_data_controller.self-1371f906b324fc840d914e1c310690030efb33d718eb408b5ee8836ed3ce1c34.js?body=1:229:18)
    at fn (eval at compile (http://localhost:3000/assets/angular/angular.self-4d4ad11d5ffcf4b45937b602ad6794ec0402cf414a488a6e28edf2a00bb8370c.js?body=1:15652:15), <anonymous>:4:324)
    at t.destination.(anonymous function) [as onRowClick] (http://localhost:3000/assets/angular/angular.self-4d4ad11d5ffcf4b45937b602ad6794ec0402cf414a488a6e28edf2a00bb8370c.js?body=1:10761:22)
    at fn (eval at compile (http://localhost:3000/assets/angular/angular.self-4d4ad11d5ffcf4b45937b602ad6794ec0402cf414a488a6e28edf2a00bb8370c.js?body=1:15652:15), <anonymous>:4:358)
    at callback (http://localhost:3000/assets/angular/angular.self-4d4ad11d5ffcf4b45937b602ad6794ec0402cf414a488a6e28edf2a00bb8370c.js?body=1:27476:17)
    at Scope.$eval (http://localhost:3000/assets/angular/angular.self-4d4ad11d5ffcf4b45937b602ad6794ec0402cf414a488a6e28edf2a00bb8370c.js?body=1:18543:28)
    at Scope.$apply (http://localhost:3000/assets/angular/angular.self-4d4ad11d5ffcf4b45937b602ad6794ec0402cf414a488a6e28edf2a00bb8370c.js?body=1:18642:25)
    at HTMLTableRowElement.<anonymous> (http://localhost:3000/assets/angular/angular.self-4d4ad11d5ffcf4b45937b602ad6794ec0402cf414a488a6e28edf2a00bb8370c.js?body=1:27481:23)
    at HTMLTableRowElement.dispatch (http://localhost:3000/assets/jquery/dist/jquery.self-25ca496239ae8641a09627c8aace5863e7676e465fbb4ce81bc7eb78c4d15627.js?body=1:4738:27)
    at HTMLTableRowElement.elemData.handle (http://localhost:3000/assets/jquery/dist/jquery.self-25ca496239ae8641a09627c8aace5863e7676e465fbb4ce81bc7eb78c4d15627.js?body=1:4550:28)
(anonymous) @ angular.self-4d4ad11d5ffcf4b45937b602ad6794ec0402cf414a488a6e28edf2a00bb8370c.js:14801

[himdel]

This happens because item.id is a number now, not a string :(.

Most likely caused by the from_cid removal PR .. fixing by forcing id to be a string server side.

EDIT: #2482 only exposed it, this is because provider_foreman overrides list_row_id and is missing the to_s there