Quadicon definition needs refactoring

[karelhala]

Missing quadicon definition

When new provider has quadicon visible, there is no place to define qhich square should have which value and new if/case has to be added to let's say quadicon_helper.rb#L555
. This is not good aproach since there is no way to move this to JSON and ask for such things over API, not talking about new providers making code less readable.

Related UI part

[karelhala]

ping @skateman @himdel @martinpovolny any suggestion about this? I guess decorator would be nice (am I correct), but let's discuss the format and what should be returned from such function.

[skateman]

@karelhala decorator sounds nice, we already have a fonticon and a fileicon there, so it would be logical to have a quadicon 🍷

def quadicon(_n = nil)
  {
    :topLeft     => {:fonticon => fonticon},
    :topRight    => {:text => servers.count,
    :bottomleft  => {:tooltip => power_state, :fileicon => ...},
    :bottomRight => {:text => templates.count}
  }
end

The values on the right side can be both methods on the record that's being decorated or methods of the decorator. For compatibility I would like to reserve at least one argument to set the size of the quad (1 or 4) but for now don't use that. What do you think @himdel && @martinpovolny?

[himdel]

bottomLeft ;)

Otherwise agreed :).

(The code calling this should probably make sure that either only :single is provided, or all of :topLeft, :topRight, :bottomLeft and :bottomRight are there. :).

And we should probably document all the possibilities (I'm thinking :policy => true for the yellow shield thing, etc.).

[skateman]

bottom_left is more ruby-like

[himdel]

And more readable 👍

[skateman]

@karelhala this can be closed