-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing PatternFly layouts for most of our screens #1884
Comments
@karelhala thanks for reaching out! Overall i think this makes sense .. I'll set up a meeting for next week to start discussing this! |
cc/ @dclarizio |
This issue in particular should be addressed in PF. The top right menu disappears in the mobile layout. The other issues are specific to CF. |
@serenamarie125 : any progress here? |
This issue has been automatically marked as stale because it has not been updated for at least 6 months. If you can still reproduce this issue on the current release or on Thank you for all your contributions! |
@miq-bot rm_label stale |
Ping @terezanovotna, @Rohoover More inputs for our PF & styling discussion in this issue ;-) |
Thanks Martin! Tereza is working on some of this now. |
@miq-bot add-label ux/review |
This issue has been automatically marked as stale because it has not been updated for at least 6 months. If you can still reproduce this issue on the current release or on Thank you for all your contributions! |
@miq-bot add_label pinned |
@miq-bot remove_label stale |
@miq-bot assign @epwinchell |
/cc @h-kataria |
Closing, We might be able to do this for patternfly 4, but that's unlikely to happen as the 2 versions can't be used together. We may need to maintain our own patterns indefinitely. |
In recent days we were revisiting the page layout of most of our screens with @epwinchell, @skateman and @himdel. We found a lot of inconsistencies with PatternFly layouts. Sadly in the past we had to hack our way around with some JavaScript that calculates the height of various elements, which starts to be a huge technical debt and it blocks any future development in the area.
We are trying to be consistent with PF as much as possible, but some layouts that we use are not implemented:
Mostly it can be observed on pagination which had to be forced to be on bottom of the page with ugly
JavaScript. It works as-is yet it break sometimes. I would like to open a discussion with @serenamarie125 about these patterns. We can help you moving our working stuff to PF repositories and we would need help with the bad stuff and missing layouts.
The text was updated successfully, but these errors were encountered: