Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing PatternFly layouts for most of our screens #1884

Closed
karelhala opened this issue Aug 10, 2017 · 15 comments
Closed

Missing PatternFly layouts for most of our screens #1884

karelhala opened this issue Aug 10, 2017 · 15 comments

Comments

@karelhala
Copy link
Contributor

In recent days we were revisiting the page layout of most of our screens with @epwinchell, @skateman and @himdel. We found a lot of inconsistencies with PatternFly layouts. Sadly in the past we had to hack our way around with some JavaScript that calculates the height of various elements, which starts to be a huge technical debt and it blocks any future development in the area.

We are trying to be consistent with PF as much as possible, but some layouts that we use are not implemented:

  • Vertically resizable sidebar (we have it, it works well, but it should be the part of PF)
  • Sidebar accordions snapped to the bottom of the page (we have it and it's badly implemented)
  • Footer (completely implemented by us, no UX patterns for this)
  • Tertiary navigation with a sidebar (most of our hacks, does not work on smaller screens)
  • All the possible permutations of the previous layouts

selection_195

Mostly it can be observed on pagination which had to be forced to be on bottom of the page with ugly
JavaScript. It works as-is yet it break sometimes. I would like to open a discussion with @serenamarie125 about these patterns. We can help you moving our working stuff to PF repositories and we would need help with the bad stuff and missing layouts.

@serenamarie125
Copy link

@karelhala thanks for reaching out! Overall i think this makes sense .. I'll set up a meeting for next week to start discussing this!

@epwinchell
Copy link
Contributor

cc/ @dclarizio

@epwinchell
Copy link
Contributor

Tertiary navigation with a sidebar (most of our hacks, does not work on smaller screens)

This issue in particular should be addressed in PF. The top right menu disappears in the mobile layout. The other issues are specific to CF.

@martinpovolny
Copy link
Member

@serenamarie125 : any progress here?

@miq-bot
Copy link
Member

miq-bot commented Jun 11, 2018

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@miq-bot miq-bot added the stale label Jun 11, 2018
@skateman
Copy link
Member

@miq-bot rm_label stale

@miq-bot miq-bot removed the stale label Jun 11, 2018
@martinpovolny
Copy link
Member

Ping @terezanovotna, @Rohoover

More inputs for our PF & styling discussion in this issue ;-)

@Rohoover
Copy link

@martinpovolny

Thanks Martin! Tereza is working on some of this now.

@terezanovotna
Copy link

@miq-bot add-label ux/review


@miq-bot miq-bot added the stale label Jan 7, 2019
@miq-bot
Copy link
Member

miq-bot commented Jan 7, 2019

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@skateman
Copy link
Member

skateman commented Jan 7, 2019

@miq-bot add_label pinned

@JPrause
Copy link
Member

JPrause commented Jan 28, 2019

@miq-bot remove_label stale

@miq-bot miq-bot removed the stale label Jan 28, 2019
@miq-bot miq-bot assigned epwinchell and skateman and unassigned epwinchell Oct 24, 2019
@epwinchell
Copy link
Contributor

@miq-bot assign @epwinchell

@miq-bot miq-bot assigned epwinchell and unassigned skateman Oct 24, 2019
@h-kataria h-kataria added redesign Screen Redesign react labels Apr 3, 2020
@epwinchell epwinchell removed their assignment Jun 27, 2020
@gtanzillo
Copy link
Member

/cc @h-kataria

@himdel
Copy link
Contributor

himdel commented Jun 30, 2020

Closing,
it would still be nice to have upstream layouts for our patterns,
but I don't think we can expect these in patternfly 3 anymore.

We might be able to do this for patternfly 4, but that's unlikely to happen as the 2 versions can't be used together.
Carbon seems more concerned with primitives than whole layouts and patterns, so I don't think it makes sense to push there either. (It does make sense to use what they have implemented, if realistic.)

We may need to maintain our own patterns indefinitely.

@himdel himdel closed this as completed Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests