Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The event catcher fails for an host with a null hostname #505

Closed
carbonin opened this issue Dec 19, 2019 · 3 comments
Closed

The event catcher fails for an host with a null hostname #505

carbonin opened this issue Dec 19, 2019 · 3 comments

Comments

@carbonin
Copy link
Member

Seeing this after adding the same provider as in #503

[----] I, [2019-12-19T17:51:48.407958 #11054:2ab1a6d9a5f8]  INFO -- : Starting ManageIQ::Providers::Vmware::InfraManager::EventCatcher with runner options {:ems_id=>"2", :guid=>"43a315ba-39ff-4326-99a6-89b3af48b1ee"}
[----] I, [2019-12-19T17:51:48.451836 #11054:2ab1a6d9a5f8]  INFO -- : Deleting worker record for ManageIQ::Providers::Vmware::InfraManager::EventCatcher, id 310
/home/ncarboni/Source/manageiq/app/models/manageiq/providers/base_manager/event_catcher/runner.rb:63:in `log_prefix': undefined method `hostname' for nil:NilClass (NoMethodError)
        from /home/ncarboni/Source/manageiq/app/models/miq_worker/runner.rb:242:in `sync_config'
        from /home/ncarboni/Source/manageiq/app/models/miq_worker/runner.rb:52:in `worker_initialization'
        from /home/ncarboni/Source/manageiq/app/models/miq_worker/runner.rb:42:in `initialize'
        from /home/ncarboni/Source/manageiq/lib/workers/bin/run_single_worker.rb:113:in `new' 
        from /home/ncarboni/Source/manageiq/lib/workers/bin/run_single_worker.rb:113:in `<main>'
@carbonin
Copy link
Member Author

FWIW this looks like a thread reporting an error after the process exits.
That's why there's no ERROR log.

@agrare
Copy link
Member

agrare commented Dec 20, 2019

Hm interesting I don't see this with that provider with current master, that's the @ems variable in the base_manager so if log_prefix were called before after_initialize this would always happen.

@carbonin was this with any changes to the worker monitor in core?

@carbonin
Copy link
Member Author

carbonin commented Jan 6, 2020

Yeah, this seems to be an issue with my patch here ManageIQ/manageiq#19666

Sorry for the noise.

@carbonin carbonin closed this as completed Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants