From 77b4aadcaed2bd170999d0fe32b6f3f3cf120048 Mon Sep 17 00:00:00 2001 From: Adam Grare Date: Fri, 13 Oct 2017 08:12:50 -0400 Subject: [PATCH 1/2] Cleanup duplicate refresher methods These two methods are duplicates of what is in the refresher mixin so they can be removed --- .../providers/lenovo/physical_infra_manager/refresher.rb | 9 --------- 1 file changed, 9 deletions(-) diff --git a/app/models/manageiq/providers/lenovo/physical_infra_manager/refresher.rb b/app/models/manageiq/providers/lenovo/physical_infra_manager/refresher.rb index d2e231a059..30429e10e0 100644 --- a/app/models/manageiq/providers/lenovo/physical_infra_manager/refresher.rb +++ b/app/models/manageiq/providers/lenovo/physical_infra_manager/refresher.rb @@ -9,14 +9,5 @@ def parse_legacy_inventory(ems) ManageIQ::Providers::Lenovo::PhysicalInfraManager::RefreshParser.ems_inv_to_hashes(ems, refresher_options) end - - def save_inventory(ems, target, hashes) - EmsRefresh.save_ems_inventory(ems, hashes) - end - - def post_process_refresh_classes - [] - end - end end From 7fd4146924bd291a12985bacaa4127d9077f9d46 Mon Sep 17 00:00:00 2001 From: Adam Grare Date: Fri, 13 Oct 2017 08:43:56 -0400 Subject: [PATCH 2/2] Refresh target can't be a hash --- .../providers/lenovo/physical_infra_manager/refresher_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/models/manageiq/providers/lenovo/physical_infra_manager/refresher_spec.rb b/spec/models/manageiq/providers/lenovo/physical_infra_manager/refresher_spec.rb index 38a901f085..87d5aa2248 100644 --- a/spec/models/manageiq/providers/lenovo/physical_infra_manager/refresher_spec.rb +++ b/spec/models/manageiq/providers/lenovo/physical_infra_manager/refresher_spec.rb @@ -30,7 +30,7 @@ it 'will save the inventory' do ems.authentications = [auth] - refresher.save_inventory(ems, {}, {}) + refresher.save_inventory(ems, nil, {}) end it 'will execute post_process_refresh_classes' do