Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'try' in case its a v2 tower which doesn't have v3 attr #17

Merged
merged 1 commit into from
Jul 24, 2017
Merged

'try' in case its a v2 tower which doesn't have v3 attr #17

merged 1 commit into from
Jul 24, 2017
+2 −2

Conversation

jameswnl
Copy link
Contributor

@jameswnl jameswnl commented Jul 21, 2017 •
edited
Loading

Opened a BZ https://bugzilla.redhat.com/show_bug.cgi?id=1478572

E.g. the domain attribute doesn't exists in v2 Tower. We need to implement this pivotal ticket ultimately. But for now this should be good enough.

@miq-bot add_labels bug, fine/yes

@miq-bot
Copy link
Member

miq-bot commented Jul 21, 2017

Checked commit https://github.com/jameswnl/manageiq-providers-ansible_tower/commit/58e1f15f3028f4d96ce424c9ffe35d4eb57a937a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@blomquisg blomquisg merged commit 2776915 into ManageIQ:master Jul 24, 2017
@blomquisg blomquisg added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 24, 2017
@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

@jameswnl Is there a BZ for this? Can you please create if it doesn't exist?

@jameswnl jameswnl deleted the tower-v2 branch August 8, 2017 15:46
@simaishi
Copy link
Contributor

Fine backport (to manageiq repo) details:

$ git log -1
commit b09a5f8349af4323de3215865bbd7b1cd2073530
Author: Greg Blomquist <[email protected]>
Date:   Mon Jul 24 15:39:58 2017 -0400

    Merge pull request #17 from jameswnl/tower-v2
    
    'try' in case its a v2 tower which doesn't have v3 attr
    (cherry picked from commit 27769150184811781f440705e50aeaa26e19067b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1484904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jameswnl @miq-bot @simaishi @blomquisg