Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and provide spec tests for the changes in PR 301 #315

Closed
gmcculloug opened this issue May 31, 2018 · 2 comments
Closed

Refactor and provide spec tests for the changes in PR 301 #315

gmcculloug opened this issue May 31, 2018 · 2 comments
Labels
refactoring test v2v

Comments

@gmcculloug
Copy link
Member

gmcculloug commented May 31, 2018 •
edited
Loading

The main methods in PR #301 need to be broken down into smaller methods with proper testing.

cc @fdupont-redhat
@gmcculloug gmcculloug changed the title Refactor and provide spec tests for the changes in PR https://github.com/ManageIQ/manageiq/pull/17293 Refactor and provide spec tests for the changes in PR #17293 May 31, 2018
@gmcculloug gmcculloug changed the title Refactor and provide spec tests for the changes in PR #17293 Refactor and provide spec tests for the changes in PR 17293 May 31, 2018
@gmcculloug gmcculloug mentioned this issue May 31, 2018
Merged
@gmcculloug gmcculloug changed the title Refactor and provide spec tests for the changes in PR 17293 Refactor and provide spec tests for the changes in PR 301 May 31, 2018
@ghost
Copy link

ghost commented Jul 13, 2018

Spec tests are tracked in #360

@gmcculloug
Copy link
Member Author

Closing in favor of Issue #360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring test v2v
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gmcculloug