Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of the new create_service_provision_request method is inconsistent with other create_*_request methods #33

Closed
ghost opened this issue Jun 2, 2017 · 0 comments
Closed

Use of the new create_service_provision_request method is inconsistent with other create_*_request methods #33

ghost opened this issue Jun 2, 2017 · 0 comments

Comments

@ghost
Copy link

ghost commented Jun 2, 2017

The new create_service_provision_request method is called directly from $evm, however the 2 'sibling' methods create_automation_request and create_provision_request are called via $evm.execute. This is inconsistent and potentially confusing.

Suggest we move create_service_provision_request into MiqAeServiceMethods for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants