Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Timezone and Date and Time configuration #99

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Oct 10, 2019

Both of these can be done using the Cockpit UI
https://bugzilla.redhat.com/show_bug.cgi?id=1745895

Intended for backport to Ivanchuk

@miq-bot
Copy link
Member

miq-bot commented Oct 10, 2019

Checked commit bdunne@79360a8 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

lib/manageiq/appliance_console/cli.rb

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just discussed that we have things like this in advanced settings:

:ntp:
  :server:
  - 0.pool.ntp.org
  - 1.pool.ntp.org
  - 2.pool.ntp.org

We might have some UI around configuring ntp servers. This might all be deletable if we can do this in cockpit. For future "fun"..

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️ 🔥 ✂️ 🔥 ✂️ 🔥

🍰 🍪 👏 🙇 😍 🎉

@jrafanie jrafanie self-assigned this Oct 15, 2019
@jrafanie jrafanie merged commit 24c35d2 into ManageIQ:master Oct 15, 2019
@jrafanie jrafanie modified the milestones: Sprint 122 Ending Oct 14, 2019, Sprint 123 Ending Oct 28, 2019 Oct 15, 2019
@bdunne bdunne deleted the remove_time_configuration branch October 15, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants