[1LP][RFR] Adding service dialog multi drop test #9998
Conversation
niyazRedhat
force-pushed
the
multi-dialog-bz
branch
3 times, most recently
from
9c6f2e1 to
9ccf80d
Compare
niyazRedhat
changed the title
|
|
||
| @pytest.mark.meta(automates=[1559030]) | ||
| @pytest.mark.tier(2) | ||
| @pytest.mark.customer_scenario |
|
|
||
| # update dialog element | ||
| view = appliance.browser.create_view(EditElementView) | ||
| view.element.edit_element(ele_label) |
There was a problem hiding this comment.
Isn't this navigation(navigate_to(sd, "Edit")) helps to reach at this page - EditElementView?
There was a problem hiding this comment.
No, after reaching to edit view page. we navigate to EditElement page to edit the element . , I think we have to navigate by EditElementView here
| # no error should be displayed | ||
| view = sd.create_view(DetailsDialogView) | ||
| view.wait_displayed() | ||
| view.flash.assert_success_message(f'{sd.label} was saved') |
There was a problem hiding this comment.
I think: you can add wait in create_view(DetailsDialogView). No need of view.wait_displayed().
There was a problem hiding this comment.
there is some issue with wait . view.wait_displayed() would be nice here.
There was a problem hiding this comment.
can you please point that issue here? Is GH issue created for it?
There was a problem hiding this comment.
not sure the issue but i heard that and there is one PR of Parthvi https://github.com/ManageIQ/integration_tests/pull/9978/files#diff-1af1dca8d2ad3e8627bac286076744ebR491
There was a problem hiding this comment.
@valaparthvi any issue you know related to wait?
There was a problem hiding this comment.
I don't think there is any problem with create_view's wait. That problem was with FlashMessages widget. I think the widget stopped supporting wait argument.
There was a problem hiding this comment.
Thanks @valaparthvi @niyazRedhat
| view = sd.create_view(DetailsDialogView) | ||
| view.wait_displayed() | ||
| view.flash.assert_success_message(f'{sd.label} was saved') | ||
| view.flash.assert_no_error() |
There was a problem hiding this comment.
Why do we need this assertion as we already checking assert message?
ganeshhubale
added
customer-case
test-automation
ganeshhubale
changed the title
niyazRedhat
force-pushed
the
multi-dialog-bz
branch
from
9ccf80d to
162c736
Compare
niyazRedhat
changed the title
niyazRedhat
force-pushed
the
multi-dialog-bz
branch
from
162c736 to
c4b7078
Compare
| # no error should be displayed | ||
| view = sd.create_view(DetailsDialogView) | ||
| view.wait_displayed() | ||
| view.flash.assert_success_message(f'{sd.label} was saved') |
There was a problem hiding this comment.
Thanks @valaparthvi @niyazRedhat
ganeshhubale
changed the title
Purpose or Intent
PRT Run
{{pytest: cfme/tests/services/test_dialog_element_in_catalog.py::test_save_dynamic_multi_drop_down_dialog }}