Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR]Test delete cloud provider dashboard after network provider delete #9997

Merged
merged 4 commits into from
Apr 8, 2020
Merged

[1LP][RFR]Test delete cloud provider dashboard after network provider delete #9997

merged 4 commits into from
Apr 8, 2020

Conversation

mmojzis
Copy link
Contributor

@mmojzis mmojzis commented Mar 18, 2020

Added test coverage for BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1632750
{{ pytest: -k "test_cloud_provider_dashboard_after_child_provider_remove" -v}}

@mmojzis mmojzis changed the title [WIPTEST]Test delete cloud provider dashboard after network provider delete [RFR]Test delete cloud provider dashboard after network provider delete Mar 19, 2020
@mmojzis mmojzis force-pushed the test_delete_cloud_provider_dashboard_after_network_provider_delete branch from e2d26ae to b1c3f41 Compare March 23, 2020 13:02
john-dupuy
john-dupuy approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small point about removing the provider in between provider types.

cfme/tests/cloud/test_providers.py Show resolved Hide resolved
@john-dupuy john-dupuy changed the title [RFR]Test delete cloud provider dashboard after network provider delete [1LP][WIPTEST]Test delete cloud provider dashboard after network provider delete Mar 23, 2020
@dajoRH dajoRH changed the title [1LP][WIPTEST]Test delete cloud provider dashboard after network provider delete [1LP][WIP]Test delete cloud provider dashboard after network provider delete Mar 26, 2020
@mmojzis mmojzis force-pushed the test_delete_cloud_provider_dashboard_after_network_provider_delete branch 2 times, most recently from 7ea28f3 to 3de6145 Compare March 26, 2020 15:53
@mmojzis mmojzis changed the title [1LP][WIP]Test delete cloud provider dashboard after network provider delete [1LP][WIPTEST]Test delete cloud provider dashboard after network provider delete Mar 26, 2020
@dajoRH
Copy link
Contributor

dajoRH commented Mar 26, 2020

I detected some fixture changes in commit 3de6145068b9056bc4df596fe6421cfbaf64346b

The local fixture child_provider is used in the following files:

  • cfme/tests/cloud/test_providers.py

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@mmojzis mmojzis changed the title [1LP][WIPTEST]Test delete cloud provider dashboard after network provider delete [1LP][RFR]Test delete cloud provider dashboard after network provider delete Mar 26, 2020
@mshriver mshriver self-assigned this Mar 27, 2020
@mshriver mshriver changed the title [1LP][RFR]Test delete cloud provider dashboard after network provider delete [1LP][WIPTEST]Test delete cloud provider dashboard after network provider delete Mar 27, 2020
mshriver
mshriver suggested changes Mar 27, 2020
View reviewed changes
Copy link
Member

@mshriver mshriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to address the alert behavior on delete better.

@dajoRH dajoRH added needs-lint and removed lint-ok labels Mar 30, 2020
@mmojzis mmojzis force-pushed the test_delete_cloud_provider_dashboard_after_network_provider_delete branch from 733b96f to f65158a Compare March 30, 2020 14:35
@dajoRH dajoRH added lint-ok and removed needs-lint labels Mar 30, 2020
@mmojzis mmojzis force-pushed the test_delete_cloud_provider_dashboard_after_network_provider_delete branch from f65158a to 3e4de9e Compare March 30, 2020 16:16
@dajoRH dajoRH added needs-lint and removed lint-ok labels Mar 30, 2020
@mmojzis mmojzis force-pushed the test_delete_cloud_provider_dashboard_after_network_provider_delete branch from 3e4de9e to 71d02aa Compare March 30, 2020 16:24
@dajoRH dajoRH added lint-ok and removed needs-lint labels Mar 30, 2020
@mmojzis mmojzis changed the title [1LP][WIPTEST]Test delete cloud provider dashboard after network provider delete [1LP][RFR]Test delete cloud provider dashboard after network provider delete Mar 30, 2020
@dajoRH dajoRH changed the title [1LP][RFR]Test delete cloud provider dashboard after network provider delete [1LP][WIP]Test delete cloud provider dashboard after network provider delete Mar 31, 2020
@mmojzis mmojzis force-pushed the test_delete_cloud_provider_dashboard_after_network_provider_delete branch from 71d02aa to b96013e Compare April 2, 2020 13:34
@mmojzis mmojzis changed the title [1LP][WIP]Test delete cloud provider dashboard after network provider delete [1LP][RFR]Test delete cloud provider dashboard after network provider delete Apr 2, 2020
@mshriver mshriver merged commit 7ad76b1 into ManageIQ:master Apr 8, 2020
ganeshhubale pushed a commit to ganeshhubale/integration_tests that referenced this pull request Jul 21, 2020
[1LP][RFR]Test delete cloud provider dashboard after network provider…
efb034f 
… delete (ManageIQ#9997)

* Added test test_delete_cloud_provider_dashboard_after_network_provider_delete

* Added coverage for BZ 1632750

* Added blocker

* delete child provider with cancel kwarg
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@john-dupuy john-dupuy john-dupuy approved these changes

@mshriver mshriver mshriver approved these changes

@jarovo jarovo jarovo approved these changes

Assignees

@mshriver mshriver

Labels
lint-ok new-test-or-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmojzis @dajoRH @jarovo @mshriver @john-dupuy