[1LP][RFR] - Service Dialog test #9995

dgaikwad · 2020-03-18T07:43:34Z

Adding new test - Test to check Load values on init option in service dialog when Dynamix box enable

Purpose or Intent

PRT Run

{{pytest: cfme/tests/services/test_dialog_element_in_catalog.py::test_catalog_load_values_on_init --long-running -v}}

ganeshhubale · 2020-03-18T10:55:17Z

cfme/tests/services/test_dialog_element_in_catalog.py

+    assert view.element_information.dynamic_chkbox.is_enabled
+    view.options.click()
+    assert view.options.load_values_on_init.is_enabled
+    request.addfinalizer(dialog.delete_if_exists)



Put request.addfinalizer(dialog.delete_if_exists) above the assert. If assert gets failed then it will not work.

ganeshhubale · 2020-03-18T10:56:12Z

cfme/tests/services/test_dialog_element_in_catalog.py

+        }
+    }
+    dialog, element = create_dialog(appliance, element_data)
+    view = appliance.browser.create_view(EditElementView)


can we make create_dialog - fixture if it is setup.

ganeshhubale · 2020-03-18T10:57:57Z

cfme/tests/services/test_dialog_element_in_catalog.py

+                           box_desc="my box desc")
+    element = box.elements.create(element_data=[element_data])
+    return sd, element
+


Instead of this function. please check if you can use this fixture in this file: https://github.com/ManageIQ/integration_tests/pull/9995/files#diff-faeac2d3d489ac01e0ebae6983c9c3cbR36

Actually I do not want to pass same input to create_dialog so kept it as a function instead of fixture

you are already passing input dialog, element = create_dialog(appliance, element_data).

Also, for now, I can see this function used for this test case only, Want to know use of label=None argument here? or we can directly provide sd = service_dialog.create(label=fauxfactory.gen_alphanumeric(15, start="label_"), description="my dialog")

I have updated the function signature now

ganeshhubale

@dgaikwad Some more questions. Please have a look :)

cfme/tests/services/test_dialog_element_in_catalog.py

ganeshhubale · 2020-03-18T12:56:30Z

cfme/tests/services/test_dialog_element_in_catalog.py

+                           box_desc="my box desc")
+    element = box.elements.create(element_data=[element_data])
+    return sd, element
+


you are already passing input dialog, element = create_dialog(appliance, element_data).

Also, for now, I can see this function used for this test case only, Want to know use of label=None argument here? or we can directly provide sd = service_dialog.create(label=fauxfactory.gen_alphanumeric(15, start="label_"), description="my dialog")

john-dupuy · 2020-03-23T19:04:57Z

@ganeshhubale can we move this to 1LP?

ganeshhubale

Need to update this PR with tier marker :)
Thanks @john-dupuy I will move it to 1LP once done with that suggestion

cfme/tests/services/test_dialog_element_in_catalog.py

dgaikwad · 2020-03-24T06:49:33Z

@ganeshhubale required changes are done, please review PR.

digitronik

Nice PR.
@dgaikwad I found one fixture in same file which is creating dialog. Please check it is possible to use same with some modification.

digitronik · 2020-03-25T10:28:01Z

cfme/tests/services/test_dialog_element_in_catalog.py

@@ -88,6 +87,18 @@ def custom_categories(appliance):
    category.delete_if_exists()


+def create_dialog(appliance, element_data):


is it possible to use fallowing fixture?
https://github.com/ManageIQ/integration_tests/pull/9995/files#diff-faeac2d3d489ac01e0ebae6983c9c3cbL38

Hello @digitronik , I have tried with fixture which you mentioned here but this fixture is test_required_dialog_elements test-case specific fixture so can not use as normal generic fixture. So now instead of using normal function I have created one generic fixture and automated testcase. from now new testcase also can use new implemented create_service_dialog fixture.

digitronik · 2020-03-25T10:30:29Z

cfme/tests/services/test_dialog_element_in_catalog.py

+    view.element.edit_element(element_data['element_information']['ele_label'])
+    assert view.element_information.dynamic_chkbox.is_enabled
+    view.options.click()
+    request.addfinalizer(dialog.delete_if_exists)


Best practice: Always put finalizer after step of creation. here I think your dialog creating at L804.

dajoRH · 2020-03-26T09:02:19Z

I detected some fixture changes in commit 9104c441479ab3d4abf3cdc5d07d11ead7273e73

The local fixture service_dialog is used in the following files:

cfme/tests/services/test_dialog_element_in_catalog.py
- catalog_item_local
- test_required_dialog_elements
- test_catalog_load_values_on_init

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

digitronik

Nice PR. One question please take look.

digitronik · 2020-03-31T08:47:19Z

cfme/tests/services/test_dialog_element_in_catalog.py

@@ -718,13 +746,18 @@ def test_load_values_on_init_option_service_dialog_element():
        casecomponent: Services
        initialEstimate: 1/16h
        testSteps:
-            1. create a service dialog
+            1. create a service dialog with option dynamic to True


It looks like part of test steps not setup. If yes, I would try to create dynamic service dialog as part of test only.
Second thought if it setup; we already have one fixture service_dialog better try to modify that in state of creating new fixture.

dialog creation is part of testcase so updated tc accordingly.

digitronik

LGTM

dajoRH added lint-ok WIP-testing labels Mar 18, 2020

dgaikwad force-pushed the test_catalog_load_values_on_init branch from a53d11a to fb4aade Compare March 18, 2020 09:53

dgaikwad changed the title ~~[WIPTEST] - Service Dialog test~~ [RFR] - Service Dialog test Mar 18, 2020

dajoRH removed the WIP-testing label Mar 18, 2020

ganeshhubale suggested changes Mar 18, 2020

View reviewed changes

ganeshhubale added the test-automation To be applied on PR's which are automating existing manual cases label Mar 18, 2020

ganeshhubale changed the title ~~[RFR] - Service Dialog test~~ [WIPTEST] - Service Dialog test Mar 18, 2020

dajoRH added the WIP-testing label Mar 18, 2020

dgaikwad force-pushed the test_catalog_load_values_on_init branch from fb4aade to 100d0b5 Compare March 18, 2020 12:12

dgaikwad changed the title ~~[WIPTEST] - Service Dialog test~~ [RFR] - Service Dialog test Mar 18, 2020

dajoRH removed the WIP-testing label Mar 18, 2020

ganeshhubale suggested changes Mar 18, 2020

View reviewed changes

ganeshhubale changed the title ~~[RFR] - Service Dialog test~~ [WIPTEST] - Service Dialog test Mar 18, 2020

dajoRH added the WIP-testing label Mar 18, 2020

dgaikwad force-pushed the test_catalog_load_values_on_init branch from 100d0b5 to aaafd6a Compare March 18, 2020 14:16

dgaikwad changed the title ~~[WIPTEST] - Service Dialog test~~ [RFR] - Service Dialog test Mar 18, 2020

dgaikwad requested a review from ganeshhubale March 18, 2020 14:39

dajoRH removed the WIP-testing label Mar 18, 2020

ganeshhubale suggested changes Mar 24, 2020

View reviewed changes

cfme/tests/services/test_dialog_element_in_catalog.py Show resolved Hide resolved

ganeshhubale changed the title ~~[RFR] - Service Dialog test~~ [WIPTEST] - Service Dialog test Mar 24, 2020

dajoRH added the WIP-testing label Mar 24, 2020

dgaikwad force-pushed the test_catalog_load_values_on_init branch from aaafd6a to b720ed2 Compare March 24, 2020 06:29

dgaikwad changed the title ~~[WIPTEST] - Service Dialog test~~ [RFR] - Service Dialog test Mar 24, 2020

dajoRH removed the WIP-testing label Mar 24, 2020

ganeshhubale changed the title ~~[RFR] - Service Dialog test~~ [1LP][RFR] - Service Dialog test Mar 24, 2020

dajoRH changed the title ~~[1LP][RFR] - Service Dialog test~~ [1LP][WIP] - Service Dialog test Mar 24, 2020

dajoRH added the needs-rebase label Mar 24, 2020

dajoRH added the WIP label Mar 24, 2020

dgaikwad force-pushed the test_catalog_load_values_on_init branch from b720ed2 to 454b361 Compare March 25, 2020 07:22

dgaikwad changed the title ~~[1LP][WIP] - Service Dialog test~~ [1LP][WIPTEST] - Service Dialog test Mar 25, 2020

dajoRH added WIP-testing and removed needs-rebase WIP labels Mar 25, 2020

dgaikwad changed the title ~~[1LP][WIPTEST] - Service Dialog test~~ [1LP][RFR] - Service Dialog test Mar 25, 2020

dajoRH removed the WIP-testing label Mar 25, 2020

digitronik suggested changes Mar 25, 2020

View reviewed changes

digitronik self-assigned this Mar 25, 2020

digitronik changed the title ~~[1LP][RFR] - Service Dialog test~~ [1LP][WIPTEST] - Service Dialog test Mar 25, 2020

dajoRH added the WIP-testing label Mar 25, 2020

dgaikwad force-pushed the test_catalog_load_values_on_init branch 2 times, most recently from 66422ab to 9104c44 Compare March 26, 2020 09:00

dgaikwad force-pushed the test_catalog_load_values_on_init branch 2 times, most recently from d6f20cf to 7377076 Compare March 31, 2020 07:51

dgaikwad changed the title ~~[1LP][WIPTEST] - Service Dialog test~~ [1LP][RFR] - Service Dialog test Mar 31, 2020

dajoRH removed the WIP-testing label Mar 31, 2020

digitronik reviewed Mar 31, 2020

View reviewed changes

dgaikwad changed the title ~~[1LP][RFR] - Service Dialog test~~ [1LP][WIPTEST] - Service Dialog test Mar 31, 2020

dgaikwad force-pushed the test_catalog_load_values_on_init branch from 7377076 to 491bcf9 Compare March 31, 2020 09:10

Service Dialog test

247dc51

dgaikwad force-pushed the test_catalog_load_values_on_init branch from 491bcf9 to 247dc51 Compare March 31, 2020 09:11

dajoRH added the WIP-testing label Mar 31, 2020

dgaikwad changed the title ~~[1LP][WIPTEST] - Service Dialog test~~ [1LP][RFR] - Service Dialog test Mar 31, 2020

dajoRH removed the WIP-testing label Mar 31, 2020

digitronik approved these changes Mar 31, 2020

View reviewed changes

digitronik merged commit 5460ce6 into ManageIQ:master Mar 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[1LP][RFR] - Service Dialog test #9995

[1LP][RFR] - Service Dialog test #9995

dgaikwad commented Mar 18, 2020 •

edited

Loading

ganeshhubale Mar 18, 2020

ganeshhubale Mar 18, 2020

ganeshhubale Mar 18, 2020

dgaikwad Mar 18, 2020

ganeshhubale Mar 18, 2020

dgaikwad Mar 18, 2020

ganeshhubale left a comment

ganeshhubale Mar 18, 2020

john-dupuy commented Mar 23, 2020

ganeshhubale left a comment

dgaikwad commented Mar 24, 2020

digitronik left a comment

digitronik Mar 25, 2020

dgaikwad Mar 31, 2020 •

edited

Loading

digitronik Mar 25, 2020

dajoRH commented Mar 26, 2020

digitronik left a comment

digitronik Mar 31, 2020

dgaikwad Mar 31, 2020

digitronik left a comment

		@@ -88,6 +87,18 @@ def custom_categories(appliance):
		category.delete_if_exists()


		def create_dialog(appliance, element_data):

[1LP][RFR] - Service Dialog test #9995

[1LP][RFR] - Service Dialog test #9995

Conversation

dgaikwad commented Mar 18, 2020 • edited Loading

Purpose or Intent

PRT Run

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ganeshhubale left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

john-dupuy commented Mar 23, 2020

ganeshhubale left a comment

Choose a reason for hiding this comment

dgaikwad commented Mar 24, 2020

digitronik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dgaikwad Mar 31, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dajoRH commented Mar 26, 2020

digitronik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

digitronik left a comment

Choose a reason for hiding this comment

dgaikwad commented Mar 18, 2020 •

edited

Loading

dgaikwad Mar 31, 2020 •

edited

Loading