Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] datetime testcase- Feature removed in 5.11 so TC not running on 5.11 #9988

Merged
merged 1 commit into from
Mar 25, 2020
Merged

[1LP][RFR] datetime testcase- Feature removed in 5.11 so TC not running on 5.11 #9988

merged 1 commit into from
Mar 25, 2020

Conversation

dgaikwad
Copy link
Contributor

@dgaikwad dgaikwad commented Mar 16, 2020 •
edited
Loading

Feature removed in 5.11 so not running on 5.11 build
Reference: ManageIQ/manageiq-appliance_console@79360a8

Purpose or Intent

PRT Run

{{pytest: ./cfme/tests/cli/test_appliance_cli.py::test_appliance_console_cli_datetime --long-running -v}}

@dgaikwad dgaikwad changed the title [WIPTEST] Removed test because feature is not exists [RFR] Removed test because feature is not exists Mar 16, 2020
@john-dupuy
Copy link
Contributor

john-dupuy commented Mar 23, 2020 •
edited
Loading

@dgaikwad This test is still relevant to CFME 5.10, as far as I can tell

[root@<appliance-host> ~]# appliance_console_cli | grep datetime
  --datetime=<s>                Date and time, in YYYY-MM-DDTHH:MM:SS (ISO8601)

Do we want to leave this test for 5.10 and disable it for 5.11?

john-dupuy
john-dupuy suggested changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question about the relevance of this test to 5.10

@john-dupuy john-dupuy changed the title [RFR] Removed test because feature is not exists [WIPTEST] Removed test because feature is not exists Mar 23, 2020
@john-dupuy john-dupuy added the test-cleanup Test removal, collection changes, re-organization label Mar 23, 2020
@dgaikwad dgaikwad force-pushed the test_appliance_console_cli_datetime branch from bd925e9 to 10f99df Compare March 24, 2020 05:59
@dgaikwad
Copy link
Contributor Author

Thank you @john-dupuy for review, Doing changes as per your suggestion

@dgaikwad dgaikwad changed the title [WIPTEST] Removed test because feature is not exists [WIPTEST] datetime testcase- Feature removed in 5.11 so TC not running on 5.11 Mar 24, 2020
@dgaikwad dgaikwad force-pushed the test_appliance_console_cli_datetime branch 2 times, most recently from aced8a4 to b86b8a2 Compare March 24, 2020 08:09
@dgaikwad dgaikwad force-pushed the test_appliance_console_cli_datetime branch from b86b8a2 to 6ca02eb Compare March 24, 2020 10:07
@dgaikwad dgaikwad changed the title [WIPTEST] datetime testcase- Feature removed in 5.11 so TC not running on 5.11 [RFR] datetime testcase- Feature removed in 5.11 so TC not running on 5.11 Mar 24, 2020
@dgaikwad
Copy link
Contributor Author

@john-dupuy I have updated PR, please have a look once.

@dgaikwad dgaikwad requested a review from john-dupuy March 24, 2020 11:16
@john-dupuy john-dupuy changed the title [RFR] datetime testcase- Feature removed in 5.11 so TC not running on 5.11 [1LP][RFR] datetime testcase- Feature removed in 5.11 so TC not running on 5.11 Mar 24, 2020
@jawatts jawatts merged commit b8a36ae into ManageIQ:master Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@john-dupuy john-dupuy john-dupuy approved these changes

@jawatts jawatts jawatts approved these changes

Assignees
No one assigned
Labels
lint-ok test-cleanup Test removal, collection changes, re-organization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgaikwad @john-dupuy @jawatts @dajoRH