This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Fixing conversion host api for OSP #9977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnadeem92
force-pushed
the
fix_conversion_host_for_osp
branch
from
2b91baf to
1ee1c2a
Compare
sshveta
approved these changes
Mar 11, 2020
nachandr
approved these changes
Mar 11, 2020
|
PRT isn't running as the commit is not signed . |
|
I ran this PR locally and the test passed for both RHV and OSP. |
Signed-off-by: mnadeem92 <[email protected]>
mnadeem92
force-pushed
the
fix_conversion_host_for_osp
branch
from
1ee1c2a to
07fc3b7
Compare
mnadeem92
changed the title
valaparthvi
approved these changes
Mar 12, 2020
valaparthvi
changed the title
jawatts
approved these changes
Mar 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mnadeem92 [email protected]
Correcting conversion_entity value, the conversion_entity is always 'vms' for Openstack provider and it is true for all cfme version, however for RHV provider it is "hosts" till 5.11.4.X version and "vms" from 5.11.5 version.
At the moment the conversion_entity is set to "hosts" which breaks OSP related all tests, This PR will correct the same.
{{ pytest: cfme/tests/v2v/test_conversion_host_ui.py -k "test_add_conversion_host_ui_crud" --use-template-cache --provider-limit 2 --use-provider osp13-ims --use-provider vsphere67-ims }}
The above PRT failing due to issue fixed in this #PR https://github.com/ManageIQ/integration_tests/pull/9979/files