This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] UCI code for RHV shouldn't be executed for <=5.11.4 #9975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshveta
approved these changes
Mar 9, 2020
cfme/fixtures/v2v_fixtures.py
Outdated
| @@ -214,7 +214,20 @@ def vddk_url(): | |||
|
|
|||
| def get_conversion_data(appliance, target_provider): | |||
| if target_provider.one_of(RHEVMProvider): | |||
| if appliance.version < '5.11': | |||
| # Support for UCI hosts for RHV would be added in 5.11.5. | |||
| # So, this if block should be disabled until then. | |||
There was a problem hiding this comment.
We can remove this comment @nachandr . Rest looks good 👍
sshveta
changed the title
nachandr
changed the title
nachandr
force-pushed
the
revert_uci_code
branch
from
73199ac to
876d74b
Compare
nachandr
changed the title
jawatts
approved these changes
Mar 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
UCI support for RHV would be pushed to 5.11.5.
I'm reverting changes made through PR#9954 while making sure that minimal to no change would be required whenever 5.11.5 lands( with support for RHV UCI hosts).
PRT Run
{{ pytest: cfme/tests/v2v/test_v2v_smoke.py --use-template-cache --provider-limit 2 --use-provider rhv43 --use-provider vsphere67-ims }}
PRT Results
5.10 - PASS
5.11 - FAILED, like expected