This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I detected some fixture changes in commit e7607aa0f5dca94cf574b3a73d9b8e4cf0863201 The global fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
dgaikwad
force-pushed
the
app_con_menu_fix
branch
2 times, most recently
from
February 24, 2020 07:13
65f5382
to
1e73beb
Compare
dgaikwad
force-pushed
the
app_con_menu_fix
branch
from
February 27, 2020 10:16
1e73beb
to
40ba480
Compare
dgaikwad
force-pushed
the
app_con_menu_fix
branch
3 times, most recently
from
March 13, 2020 13:04
2f880ba
to
f8eef37
Compare
dgaikwad
force-pushed
the
app_con_menu_fix
branch
from
March 19, 2020 07:21
f8eef37
to
32a6b72
Compare
dgaikwad
force-pushed
the
app_con_menu_fix
branch
from
March 19, 2020 09:22
32a6b72
to
246ddcc
Compare
john-dupuy
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this PR @dgaikwad
digitronik
approved these changes
Mar 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mapping is hectic task :)
thanks for fix! PRT LGTM 👍
@@ -422,7 +424,7 @@ def test_appliance_console_extend_storage(unconfigured_appliance): | |||
1. 'ap' launches appliance_console, | |||
2. RETURN clears info screen, | |||
3. '11' extend storage, | |||
4. '2' select disk, | |||
4. select disk, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace ^^
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
Appliance console menu option's sequence changed recently so modified some testcases according to new appliance menu sequence
Due to this PR appliance console option changed
PRT Run
{{pytest: ./cfme/tests/cli/test_appliance_console.py -k "test_appliance_console_internal_db or test_appliance_console_dedicated_db or test_appliance_console_external_db or test_appliance_console_external_db_create or test_appliance_console_extend_storage or test_appliance_console_ipa or test_appliance_console_external_auth or test_appliance_console_external_auth_all or test_appliance_console_evm_stop or test_appliance_console_evm_start or test_appliance_console_shutdown or test_appliance_console_restore_db_network_negative or test_appliance_console_key_fetch_negative" -v}}