Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] - Fixed TCs #9921

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Conversation

dgaikwad
Copy link
Contributor

@dgaikwad dgaikwad commented Feb 16, 2020

Purpose or Intent

Appliance console menu option's sequence changed recently so modified some testcases according to new appliance menu sequence
Due to this PR appliance console option changed

PRT Run

{{pytest: ./cfme/tests/cli/test_appliance_console.py -k "test_appliance_console_internal_db or test_appliance_console_dedicated_db or test_appliance_console_external_db or test_appliance_console_external_db_create or test_appliance_console_extend_storage or test_appliance_console_ipa or test_appliance_console_external_auth or test_appliance_console_external_auth_all or test_appliance_console_evm_stop or test_appliance_console_evm_start or test_appliance_console_shutdown or test_appliance_console_restore_db_network_negative or test_appliance_console_key_fetch_negative" -v}}

@dajoRH
Copy link
Contributor

dajoRH commented Feb 16, 2020

I detected some fixture changes in commit e7607aa0f5dca94cf574b3a73d9b8e4cf0863201

The global fixture dedicated_db_appliance is used in the following files:

  • cfme/tests/cli/test_appliance_cli.py
    • test_appliance_console_cli_external_create
  • cfme/tests/cli/test_appliance_console.py

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@dajoRH dajoRH changed the title [WIPTEST] - Fixed TCs [WIP] - Fixed TCs Feb 20, 2020
@dgaikwad dgaikwad force-pushed the app_con_menu_fix branch 2 times, most recently from 65f5382 to 1e73beb Compare February 24, 2020 07:13
@dgaikwad dgaikwad changed the title [WIP] - Fixed TCs [WIPTEST] - Fixed TCs Feb 24, 2020
@dgaikwad dgaikwad force-pushed the app_con_menu_fix branch 3 times, most recently from 2f880ba to f8eef37 Compare March 13, 2020 13:04
@dgaikwad dgaikwad changed the title [WIPTEST] - Fixed TCs [RFR] - Fixed TCs Mar 19, 2020
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this PR @dgaikwad

@john-dupuy john-dupuy changed the title [RFR] - Fixed TCs [1LP][RFR] - Fixed TCs Mar 23, 2020
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping is hectic task :)
thanks for fix! PRT LGTM 👍

@@ -422,7 +424,7 @@ def test_appliance_console_extend_storage(unconfigured_appliance):
1. 'ap' launches appliance_console,
2. RETURN clears info screen,
3. '11' extend storage,
4. '2' select disk,
4. select disk,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace ^^

@digitronik digitronik merged commit 2a3b8d6 into ManageIQ:master Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants