This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR]Fixing the TC test_cancel_migration_attachments #9900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnadeem92
changed the title
sshveta
suggested changes
Feb 4, 2020
| @@ -174,32 +174,27 @@ def _cleanup(): | |||
| migration_plan.wait_for_state("Started") | |||
| request_details_list = migration_plan.get_plan_vm_list(wait_for_migration=False) | |||
| vm_detail = request_details_list.read()[0] | |||
| time.sleep(360) # grace time for starting disk migration | |||
There was a problem hiding this comment.
Instead of this you can check if migration plan is in progress by doing
migration_plan.wait_for_state("In_Progress") and then cancel
sshveta
changed the title
Signed-off-by: mnadeem92 <[email protected]>
mnadeem92
force-pushed
the
fix_test_cancel_migration_attachments
branch
from
5f22985 to
342aa5f
Compare
mnadeem92
changed the title
john-dupuy
approved these changes
Feb 6, 2020
sshveta
approved these changes
Feb 6, 2020
sshveta
changed the title
digitronik
reviewed
Feb 7, 2020
| # Test1: Check if instance is on openstack/rhevm provider | ||
| soft_assert(not provider.mgmt.find_vms(name=vm_obj.name)) | ||
| soft_assert(not vm_on_dest) |
There was a problem hiding this comment.
I'm suspect about this check.
why soft_assert?
are we expect that VM on Openstack/rhevm provider? if yes, why negation in an assertion?
There was a problem hiding this comment.
No, we are not expecting VM at destination.
There was a problem hiding this comment.
The TC gets failed if VM gets migrated to Destination, However for OSP the port and volumes gets attached to the VM once it gets migrated , So for OSP, we need to do additional check for port and volumes if VM gets migrated to Destination.
digitronik
approved these changes
Feb 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Test case was failing as the cancel never run due to the check we put for disk migration gets 20%, I noticed that the progress bar never shows real time value and after full disk gets migrated the progress bar certainly reached to 100%, which cause the TC failure as till the time cancel gets triggered the VM gets migrated 100% to the destination. This PR will not look for 20% instead gives a grace time of 6 minutes for migration to proceed and then cancel the migration.
{{ pytest: cfme/tests/v2v/test_v2v_cancel_migrations.py -k "test_cancel_migration_attachments" --use-provider osp13-ims --use-provider vsphere67-ims --provider-limit 2 -v }}