This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Zone test automation / parametrization #9898
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes to zone- and server-related tests:
1.) Rename test_zone_add_dupe to test_zone_add_duplicate.
2.) Move zone name and description generation out of create_zone() and into the individual tests in cfme/tests/configure/test_zones.py:. This might eventually be moved into a parametrized fixture.
3.) Automate some manual tests and remove them from cfme/tests/distributed/test_appliance_manual.py. The new automated tests are in cfme/tests/configure/test_zones.py:
test_distributed_field_zone_description_special and test_distributed_field_zone_name_special -> test_zone_add_punctuation
test_distributed_field_zone_name_whitespace and test_distributed_field_zone_description_leading_whitespace -> test_zone_add_whitespace
The new test test_zone_add_whitespace is marked with a BZ blocker for:
Bug 1797715 - Whitespace in name/description/etc. not displayed faithfully in UI
https://bugzilla.redhat.com/show_bug.cgi?id=1797715
4.) Add a small fix to the step() method in cfme.base.ui.ZoneSettings. In test_zone_add_punctuation, for example, the presence of any regex special characters in the zone description would break the navigation, so the description is now passed through re.escape() first:
5.) Move the manual server role failover tests in cfme/tests/distributed/test_appliance_manual.py:
test_distributed_zone_failover_cu_data_processor
test_distributed_migrate_embedded_ansible_role
test_distributed_zone_failover_reporting
test_distributed_zone_failover_cu_data_collector
test_distributed_zone_failover_web_services
test_distributed_zone_failover_cu_coordinator_singleton
test_distributed_zone_failover_smartstate_analysis
test_distributed_zone_failover_scheduler_singleton
test_distributed_zone_failover_provider_inventory_singleton
test_distributed_zone_failover_provider_operations
test_distributed_zone_failover_notifier_singleton
to the new parametrized test (still manual):
test_server_role_failover[role].
{{ pytest: cfme/tests/configure/test_zones.py -v }}