Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Automate: test_quota_with_reconfigure_resize_disks #9891

Merged
merged 2 commits into from
Jan 30, 2020

Conversation

valaparthvi
Copy link
Contributor

Purpose or Intent

  • Adding tests
    1. Automate test_quota_with_reconfigure_resize_disks
  • Enhancement
    1. Fixing quota property of Tenant entity.

PRT Run

{{ pytest: cfme/tests/infrastructure/test_tenant_quota.py -k "test_quota_with_reconfigure_resize_disks" -vvvv }}

@valaparthvi valaparthvi added enhancement test-automation To be applied on PR's which are automating existing manual cases labels Jan 29, 2020
@dajoRH
Copy link
Contributor

dajoRH commented Jan 30, 2020

I detected some fixture changes in commit d22a2e5

The local fixture quota_limit is used in the following files:

  • cfme/tests/infrastructure/test_tenant_quota.py
    • test_quota_with_reconfigure_resize_disks

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@valaparthvi valaparthvi changed the title [WIPTEST] Automate: test_quota_with_reconfigure_resize_disks [RFR] Automate: test_quota_with_reconfigure_resize_disks Jan 30, 2020
Copy link
Member

@ganeshhubale ganeshhubale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ganeshhubale ganeshhubale changed the title [RFR] Automate: test_quota_with_reconfigure_resize_disks [1LP][RFR] Automate: test_quota_with_reconfigure_resize_disks Jan 30, 2020
@@ -1435,14 +1435,14 @@ def quota(self):
'num_vms': 'Allocated Number of Virtual Machines',
'templates': 'Allocated Number of Templates'
}

# This table does not work normally because of colspan, this is workaround for that problem.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table widget colspan implementation should support this, we need to take a look at what's happening here. Please open an issue against wt.core so we can debug.

@mshriver mshriver merged commit 407b6e6 into ManageIQ:master Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants