[RFR] Parametrize Tower tests on API version

[nachandr]

Purpose or Intent

PRT Run

{{ pytest: cfme/tests/services/test_config_provider_servicecatalogs.py cfme/tests/services/test_ansible_workflow_servicecatalogs.py --use-provider complete}}

[mshriver]

👌 Thanks for the thorough docblock!

[mshriver]

Looking good, but I would do two things here:

1. move this assignment of original_url outside of the logic blocks, so that we don't hit any UnboundLocals
2. Make the url update regardless of ansible_api_version, so that its always explicitly set to what the test parameter is.

If we're not explicitly setting it, we risk running into situations where fixture/parameter scope, or the URL defined for the provider in the yaml, will result in the provider's configuration not matching the parametrized value for API.

This way we can remove the logic here.

[nachandr]

Done

[mshriver]

Two comments to consider - nice work though!

[mshriver]

PRT failures look unrelated to the changes here - other than MIQ's lack of support for v2 API.

[dajoRH]

I detected some fixture changes in commit 445388f

The global fixture ansible_api_version_change is used in the following files:

• cfme/tests/services/test_ansible_workflow_servicecatalogs.py
• cfme/tests/services/test_config_provider_servicecatalogs.py

The local fixture ansible_workflow_catitem is used in the following files:

• cfme/tests/services/test_ansible_workflow_servicecatalogs.py
  • test_tower_workflow_item
  • test_retire_ansible_workflow

The local fixture catalog_item is used in the following files:

• cfme/tests/services/test_config_provider_servicecatalogs.py
  • test_order_tower_catalog_item
  • test_retire_ansible_service

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃