This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Enhanced security group test case for multiple checks #9886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurilahane
changed the title
ganeshhubale
suggested changes
Jan 29, 2020
| view.paginator.set_items_per_page(item_count) | ||
| assert len(view.entities.get_all()) <= view.paginator.items_per_page | ||
| view.paginator.set_items_per_page(1000) | ||
| total_count = len(view.entities.get_all()) |
There was a problem hiding this comment.
Question:
- Why are you setting
set_items_per_pageto 1000? if it is for getting total count then please check if there is any other way available to get total count of entities.
There was a problem hiding this comment.
We can refer "view.entities.get_all(surf_pages=True)"
to surf the page for entites to get total count.
There was a problem hiding this comment.
There's a method for this in PaginationPane - https://github.com/ManageIQ/integration_tests/blob/master/widgetastic_manageiq/__init__.py#L1809
It will be slow to use get_all if there are actually 1000 items. It'll also not get the total count if there are more than 1000.
There was a problem hiding this comment.
Thanks @mshriver!
updated with your suggestion
ganeshhubale
changed the title
ganeshhubale
approved these changes
Jan 29, 2020
mayurilahane
force-pushed
the
testing_nw_manager
branch
from
8f663af to
401f249
Compare
dajoRH
changed the title
mayurilahane
force-pushed
the
testing_nw_manager
branch
from
401f249 to
9abea7d
Compare
mayurilahane
changed the title
mayurilahane
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
Enhanced as per suggestion given: https://github.com/ManageIQ/integration_tests/pull/9799/files#r366572190
PRT Run
{{ pytest: cfme/tests/cloud_infra_common/test_relationships.py::test_change_network_security_groups_per_page_items --use-provider complete --use-template-cache -qsvv }}