Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Moving custom button to use AttributeValueForm #9853

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

digitronik
Copy link
Contributor

Purpose or Intent

  • Moving custom button attributes to use AttributeValueForm
  • It will also fix failing tests

PRT Run

{{pytest: cfme/tests/automate/custom_button/test_buttons.py -k "test_button_avp_displayed or test_simulated_object_copy_on_button or test_attribute_override"}}

@digitronik digitronik changed the title [WIPTEST] Moving custom button to use AttributeValueForm [RFR] Moving custom button to use AttributeValueForm Jan 17, 2020
Copy link
Member

@ganeshhubale ganeshhubale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question otherwise LGTM :)

@ganeshhubale ganeshhubale changed the title [RFR] Moving custom button to use AttributeValueForm [1LP][RFR] Moving custom button to use AttributeValueForm Jan 20, 2020
@mshriver mshriver self-assigned this Jan 28, 2020
@mshriver mshriver merged commit 7b5690c into ManageIQ:master Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants