Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR]Implement test_add_second_provider #9848

Merged
merged 1 commit into from
Feb 14, 2020
Merged

[1LP][RFR]Implement test_add_second_provider #9848

merged 1 commit into from
Feb 14, 2020

Conversation

mmojzis
Copy link
Contributor

@mmojzis mmojzis commented Jan 16, 2020

{{ pytest: -k "test_add_second_provider" -v }}

@mmojzis mmojzis force-pushed the test_add_second_provider branch from c757e0d to c6621b9 Compare January 20, 2020 14:20
@mmojzis mmojzis changed the title [WIPTEST]Implement test_add_second_provider [RFT]Implement test_add_second_provider Jan 29, 2020
@mmojzis mmojzis changed the title [RFT]Implement test_add_second_provider [RFR]Implement test_add_second_provider Jan 29, 2020
john-dupuy
john-dupuy suggested changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, I just have one comment about adding an assertion or two the test.

cfme/tests/cloud/test_providers.py Show resolved Hide resolved
john-dupuy
john-dupuy suggested changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, I just have one comment about adding an assertion or two the test.

@john-dupuy john-dupuy changed the title [RFR]Implement test_add_second_provider [WIPTEST]Implement test_add_second_provider Jan 30, 2020
@mmojzis mmojzis force-pushed the test_add_second_provider branch from c6621b9 to 0e577d5 Compare January 31, 2020 15:31
@mmojzis mmojzis changed the title [WIPTEST]Implement test_add_second_provider [RFR]Implement test_add_second_provider Jan 31, 2020
@john-dupuy john-dupuy changed the title [RFR]Implement test_add_second_provider [1LP][RFR]Implement test_add_second_provider Jan 31, 2020
@mmojzis mmojzis force-pushed the test_add_second_provider branch 3 times, most recently from 9bd9c33 to e3550bb Compare January 31, 2020 15:37
@mmojzis mmojzis changed the title [1LP][RFR]Implement test_add_second_provider [1LP][WIPTEST]Implement test_add_second_provider Jan 31, 2020
@mmojzis mmojzis changed the title [1LP][WIPTEST]Implement test_add_second_provider [1LP][RFR]Implement test_add_second_provider Jan 31, 2020
@mmojzis mmojzis changed the title [1LP][RFR]Implement test_add_second_provider [1LP][WIPTEST]Implement test_add_second_provider Jan 31, 2020
mshriver
mshriver suggested changes Jan 31, 2020
View reviewed changes
Copy link
Member

@mshriver mshriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to use deepcopy, otherwise the original provider instance gets modified, which will impact any other tests collected in the session.

@dajoRH dajoRH changed the title [1LP][WIPTEST]Implement test_add_second_provider [1LP][WIP]Implement test_add_second_provider Feb 7, 2020
@mmojzis mmojzis force-pushed the test_add_second_provider branch from e3550bb to afde4dc Compare February 10, 2020 19:43
@mmojzis mmojzis changed the title [1LP][WIP]Implement test_add_second_provider [1LP][WIPTEST]Implement test_add_second_provider Feb 10, 2020
@mmojzis mmojzis changed the title [1LP][WIPTEST]Implement test_add_second_provider [1LP][RFR]Implement test_add_second_provider Feb 10, 2020
@mshriver mshriver self-assigned this Feb 14, 2020
@mshriver mshriver merged commit 8e9ea14 into ManageIQ:master Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@john-dupuy john-dupuy john-dupuy approved these changes

@mshriver mshriver mshriver approved these changes

Assignees

@mshriver mshriver

Labels
lint-ok new-test-or-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmojzis @mshriver @john-dupuy @dajoRH