Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[RFR] Use new_configuration rather than changes for reconfigure dict #9837

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

john-dupuy
Copy link
Contributor

Due to recent changes in the reconfigure function for reconfiguring a VM, this test is failing with

>       for network_adapters_change in changes['network_adapters']:
E       KeyError: 'network_adapters'

This is because a changes dict was supplied rather than a new_configuration dict.

if new_configuration:
changes = self.configuration.get_changes_to_fill(new_configuration)

{{ pytest: --long-running --use-provider vsphere65-nested cfme/tests/control/test_alerts.py::test_alert_hardware_reconfigured }}

@john-dupuy
Copy link
Contributor Author

Tests are failing due to firewall (closed ports) on PRT, the targeted fix is valid though.

@john-dupuy john-dupuy changed the title [WIPTEST] Use new_configuration rather than changes for my dict [RFR] Use new_configuration rather than changes for my dict Jan 13, 2020
@john-dupuy john-dupuy changed the title [RFR] Use new_configuration rather than changes for my dict [RFR] Use new_configuration rather than changes for reconfigure dict Jan 13, 2020
@mshriver mshriver self-assigned this Jan 13, 2020
@mshriver mshriver merged commit 73a425e into ManageIQ:master Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants