This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR]Implemented automated test for test_add_delete_add_provider #9832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmojzis
force-pushed
the
test_add_delete_add_provider
branch
2 times, most recently
from
e735a83 to
f4c1aee
Compare
mmojzis
changed the title
jawatts
approved these changes
Jan 30, 2020
jawatts
changed the title
mshriver
reviewed
Jan 31, 2020
| @@ -1250,8 +1250,8 @@ def test_ec2_create_sns_topic(): | |||
|
|
|||
|
|
|||
| @test_requirements.ec2 | |||
| @pytest.mark.manual | |||
| def test_ec2_add_delete_add_provider(): | |||
| @pytest.mark.provider([EC2Provider], scope="function", override=True, selector=ONE) | |||
There was a problem hiding this comment.
override kwarg is no longer necessary, and is essentially ignored (generates a log message)
mshriver
approved these changes
Jan 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{ pytest: -k "test_add_delete_add_provider" -v }}