Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR]Automated Service state test #9824

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

niyazRedhat
Copy link
Contributor

Purpose or Intent

PRT Run

{{pytest: cfme/tests/services/test_myservice.py::test_service_state --use-provider vsphere67-nested --long-running }}

@niyazRedhat niyazRedhat changed the title [WIPTEST]Automated Service state test [RFR]Automated Service state test Jan 9, 2020
@dajoRH dajoRH removed the WIP-testing label Jan 9, 2020
@ganeshhubale ganeshhubale changed the title [RFR]Automated Service state test [WIPTEST]Automated Service state test Jan 9, 2020
@ganeshhubale ganeshhubale added the test-automation To be applied on PR's which are automating existing manual cases label Jan 9, 2020
@niyazRedhat niyazRedhat changed the title [WIPTEST]Automated Service state test [RFR]Automated Service state test Jan 10, 2020
Copy link
Contributor

@sshveta sshveta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test case @niyazRedhat .
please check if you can use fixture order_service

pass
service_catalogs = ServiceCatalogs(appliance, catalog_item.catalog, catalog_item.name)
service = MyService(appliance, catalog_item.name)
service_request = service_catalogs.order()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use fixture 'order_service' that will order catalog_item and also delete service at the end.

https://github.com/ManageIQ/integration_tests/blob/master/cfme/fixtures/service_fixtures.py#L161

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sshveta we need to fail ordered service catalog item before successfully provisioned. so for that, we are removing provider while ordered catalog item is in progress hence we can not use fixture which provides successfully provision service catalog item.

@pytest.mark.ignore_stream('5.10')
@pytest.mark.tier(2)
def test_service_state():
@pytest.mark.parametrize("check", ["provisioned", "un_provisioned"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion: please replace un_provisioned <==> unprovisioned

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, I'd say it's optional though

Copy link
Contributor

@kedark3 kedark3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please address comments.

Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this PR!

@pytest.mark.ignore_stream('5.10')
@pytest.mark.tier(2)
def test_service_state():
@pytest.mark.parametrize("check", ["provisioned", "un_provisioned"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, I'd say it's optional though

@john-dupuy
Copy link
Contributor

Please check PRT for 5.10

@sshveta sshveta changed the title [RFR]Automated Service state test [WIPTEST]Automated Service state test Jan 17, 2020
@niyazRedhat niyazRedhat changed the title [WIPTEST]Automated Service state test [RFR]Automated Service state test Jan 23, 2020
@john-dupuy john-dupuy changed the title [RFR]Automated Service state test [1LP][RFR]Automated Service state test Jan 23, 2020
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR 👍
please check PRT failures on 5.11.

num_sec=300,
fail_func=view.browser.refresh)

@request.addfinalizer
Copy link
Contributor

@digitronik digitronik Jan 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always better to add finalizer just after entity created.

@digitronik digitronik changed the title [1LP][RFR]Automated Service state test [1LP][WIPTEST]Automated Service state test Jan 27, 2020
@digitronik digitronik self-assigned this Jan 28, 2020
@niyazRedhat niyazRedhat changed the title [1LP][WIPTEST]Automated Service state test [1LP][RFR]Automated Service state test Jan 28, 2020
@digitronik digitronik merged commit 8ad7873 into ManageIQ:master Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants