-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR]Automated Service state test #9824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice test case @niyazRedhat .
please check if you can use fixture order_service
pass | ||
service_catalogs = ServiceCatalogs(appliance, catalog_item.catalog, catalog_item.name) | ||
service = MyService(appliance, catalog_item.name) | ||
service_request = service_catalogs.order() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use fixture 'order_service' that will order catalog_item and also delete service at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sshveta we need to fail ordered service catalog item before successfully provisioned. so for that, we are removing provider while ordered catalog item is in progress hence we can not use fixture which provides successfully provision service catalog item.
@pytest.mark.ignore_stream('5.10') | ||
@pytest.mark.tier(2) | ||
def test_service_state(): | ||
@pytest.mark.parametrize("check", ["provisioned", "un_provisioned"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion: please replace un_provisioned
<==> unprovisioned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, I'd say it's optional though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Please address comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this PR!
@pytest.mark.ignore_stream('5.10') | ||
@pytest.mark.tier(2) | ||
def test_service_state(): | ||
@pytest.mark.parametrize("check", ["provisioned", "un_provisioned"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, I'd say it's optional though
Please check PRT for 5.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR 👍
please check PRT failures on 5.11.
num_sec=300, | ||
fail_func=view.browser.refresh) | ||
|
||
@request.addfinalizer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always better to add finalizer just after entity created.
f19f999
to
d050e46
Compare
Purpose or Intent
PRT Run
{{pytest: cfme/tests/services/test_myservice.py::test_service_state --use-provider vsphere67-nested --long-running }}