Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Replace usage of entity.check() with entity.ensure_checked. Part 3. #9821

Merged
merged 4 commits into from
Jan 22, 2020

Conversation

prichard77
Copy link
Contributor

@prichard77 prichard77 commented Jan 8, 2020

Purpose or Intent

  • Updating tests and framework to use entity ensure_checked() instead of entity.check(). ensure_checked() is an enhancement to check() functionality that accounts for the checked state of an entity when selecting it.

###PRT
{{ pytest: --long-running --use-provider ec2west cfme/tests/cloud/test_instance_power_control.py::test_power_options_on_archived_instance_all_page --use-provider rhv43 cfme/tests/infrastructure/test_vm_power_control.py::test_power_options_on_archived_orphaned_vms_all_page }}

@dajoRH dajoRH changed the title [WIPTEST] Replace usage of entity.check() with entity.ensure_checked. Part 3. [WIP] Replace usage of entity.check() with entity.ensure_checked. Part 3. Jan 9, 2020
@prichard77 prichard77 changed the title [WIP] Replace usage of entity.check() with entity.ensure_checked. Part 3. [WIPTEST] Replace usage of entity.check() with entity.ensure_checked. Part 3. Jan 9, 2020
@dajoRH dajoRH added WIP-testing and removed WIP labels Jan 9, 2020
@prichard77
Copy link
Contributor Author

Some of the changes made are executed in tests for which we have no suitable providers provisioned. For example: cfme/tests/infrastructure/test_delete_infra_object.py::test_delete_vm_appear_after_refresh

@prichard77 prichard77 changed the title [WIPTEST] Replace usage of entity.check() with entity.ensure_checked. Part 3. [RFR] Replace usage of entity.check() with entity.ensure_checked. Part 3. Jan 22, 2020
@valaparthvi valaparthvi changed the title [RFR] Replace usage of entity.check() with entity.ensure_checked. Part 3. [1LP][RFR] Replace usage of entity.check() with entity.ensure_checked. Part 3. Jan 22, 2020
@mshriver mshriver merged commit 0c177be into ManageIQ:master Jan 22, 2020
spusateri pushed a commit to spusateri/integration_tests that referenced this pull request Jan 27, 2020
…. Part 3. (ManageIQ#9821)

* Replace check() with ensure_checked() in last group of files using get_all or get_enitity

* Remove extra underscore added by mistake

* Replace check() with ensure_checked() in find_quadicon cases

* Replace check() with ensure_checked() in apply() cases using lambda
@prichard77 prichard77 deleted the replaceCheck3 branch March 10, 2020 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants