Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Fix SSA fixture for failing tests. #9813

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

sbulage
Copy link
Contributor

@sbulage sbulage commented Jan 2, 2020

Purpose or Intent

  • This PR will fix calling of parametrized fixture.

  • Error in tests:

Fixture "compare_linux_vm_data" called directly. Fixtures are not meant to be called directly,
but are created automatically when test functions request them as parameters.
See https://docs.pytest.org/en/latest/fixture.html for more information about fixtures, and
https://docs.pytest.org/en/latest/deprecations.html#calling-fixtures-directly about how to update your code.

PRT Run

{{pytest: cfme/tests/cloud_infra_common/test_vm_instance_analysis.py -k "test_ssa_compliance or test_ssa_schedule or test_ssa_vm" --use-provider vsphere65-nested --long-running -vvv}}

@sbulage sbulage changed the title [WIPTEST] Fix SSA fixture for failing tests. [RFR] Fix SSA fixture for failing tests. Jan 3, 2020
@sbulage
Copy link
Contributor Author

sbulage commented Jan 3, 2020

PRT failures are not related to changes made in this PR.

@dajoRH dajoRH removed the WIP-testing label Jan 3, 2020
@ganeshhubale ganeshhubale changed the title [RFR] Fix SSA fixture for failing tests. [1LP][RFR] Fix SSA fixture for failing tests. Jan 3, 2020
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both fixtures are pytest factory fixtures. LGTM. As per latest pytest we can not call those directly.

@digitronik digitronik self-assigned this Jan 3, 2020
@digitronik digitronik merged commit 9169cb0 into ManageIQ:master Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants