Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] NewTest::setting up ipv4 and ipv6 using invalid data #9811

Conversation

dgaikwad
Copy link
Contributor

@dgaikwad dgaikwad commented Jan 2, 2020

Purpose or Intent

  • Test to set ipv4 and ipv6 using invalid data

PRT Run

{{pytest: cfme/tests/cli/test_appliance_console.py -k "test_appliance_console_static_ip_negative" -v}}

@dgaikwad dgaikwad force-pushed the test_appliance_console_static_ip_negative branch from 0dded00 to ed35577 Compare January 2, 2020 10:37
@dajoRH dajoRH added the lint-ok label Jan 2, 2020
@dgaikwad dgaikwad changed the title NewTest::setting up ipv4 and ipv6 using invalid data [WIPTEST] NewTest::setting up ipv4 and ipv6 using invalid data Jan 2, 2020
@dgaikwad dgaikwad force-pushed the test_appliance_console_static_ip_negative branch 3 times, most recently from 7cdab06 to ce97f6e Compare January 3, 2020 08:58
@dgaikwad dgaikwad changed the title [WIPTEST] NewTest::setting up ipv4 and ipv6 using invalid data [RFR] NewTest::setting up ipv4 and ipv6 using invalid data Jan 3, 2020
@ganeshhubale ganeshhubale added the test-automation To be applied on PR's which are automating existing manual cases label Jan 3, 2020
@dajoRH dajoRH removed the WIP-testing label Jan 3, 2020
@dgaikwad dgaikwad force-pushed the test_appliance_console_static_ip_negative branch from ce97f6e to 5f448b3 Compare January 3, 2020 09:30
Copy link
Member

@ganeshhubale ganeshhubale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ganeshhubale ganeshhubale changed the title [RFR] NewTest::setting up ipv4 and ipv6 using invalid data [1LP][RFR] NewTest::setting up ipv4 and ipv6 using invalid data Jan 3, 2020
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can still improve it. Please take look

cfme/tests/cli/test_appliance_console.py Outdated Show resolved Hide resolved
cfme/tests/cli/test_appliance_console.py Outdated Show resolved Hide resolved
@digitronik digitronik changed the title [1LP][RFR] NewTest::setting up ipv4 and ipv6 using invalid data [1LP][WIPTEST] NewTest::setting up ipv4 and ipv6 using invalid data Jan 6, 2020
@dgaikwad dgaikwad force-pushed the test_appliance_console_static_ip_negative branch from 5f448b3 to daec4e9 Compare January 6, 2020 13:45
@dgaikwad dgaikwad changed the title [1LP][WIPTEST] NewTest::setting up ipv4 and ipv6 using invalid data [1LP][RFR] NewTest::setting up ipv4 and ipv6 using invalid data Jan 7, 2020
@dgaikwad dgaikwad requested a review from digitronik January 7, 2020 05:09
@dajoRH dajoRH removed the WIP-testing label Jan 7, 2020
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice PR 👍

@digitronik digitronik merged commit 623a64b into ManageIQ:master Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants