This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR] Adding new dynamic service dialog test #9789
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyazRedhat
changed the title
[WIPTEST] Adding new dynamic service dialog test
[RFR] Adding new dynamic service dialog test
Dec 19, 2019
john-dupuy
added
customer-case
test-automation
To be applied on PR's which are automating existing manual cases
labels
Dec 19, 2019
john-dupuy
suggested changes
Dec 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question about the file_name
@pytest.mark.parametrize("import_data", [DatastoreImport("bz_1364407.zip", "bz_1364407", None)], | ||
ids=["datastore"]) | ||
@pytest.mark.parametrize("file_name", ["bz_1364407.yml"], ids=["dynamic_dialog"]) | ||
def test_update_dynamic_field_on_refresh(appliance, import_datastore, import_data, file_name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see file_name
used in the test case. Why is it needed as a parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, right we don't need that. Thanks :)
john-dupuy
changed the title
[RFR] Adding new dynamic service dialog test
[WIPTEST] Adding new dynamic service dialog test
Dec 19, 2019
niyazRedhat
force-pushed
the
update_dynamic
branch
from
December 19, 2019 17:19
cbaae5f
to
515d8c0
Compare
niyazRedhat
changed the title
[WIPTEST] Adding new dynamic service dialog test
[RFR] Adding new dynamic service dialog test
Dec 19, 2019
ganeshhubale
suggested changes
Dec 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change :)
ganeshhubale
changed the title
[RFR] Adding new dynamic service dialog test
[WIPTEST] Adding new dynamic service dialog test
Dec 23, 2019
niyazRedhat
force-pushed
the
update_dynamic
branch
from
December 23, 2019 08:59
515d8c0
to
9e43d9c
Compare
niyazRedhat
changed the title
[WIPTEST] Adding new dynamic service dialog test
[RFR] Adding new dynamic service dialog test
Dec 30, 2019
ganeshhubale
approved these changes
Dec 30, 2019
ganeshhubale
changed the title
[RFR] Adding new dynamic service dialog test
[1LP][RFR] Adding new dynamic service dialog test
Dec 30, 2019
digitronik
approved these changes
Jan 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
customer-case
lint-ok
test-automation
To be applied on PR's which are automating existing manual cases
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run
{{pytest: cfme/tests/services/test_dynamicdd_dialogelement.py::test_update_dynamic_field_on_refresh --long-running}}