Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Adding new dynamic service dialog test #9789

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

niyazRedhat
Copy link
Contributor

Purpose or Intent

PRT Run

{{pytest: cfme/tests/services/test_dynamicdd_dialogelement.py::test_update_dynamic_field_on_refresh --long-running}}

@niyazRedhat niyazRedhat changed the title [WIPTEST] Adding new dynamic service dialog test [RFR] Adding new dynamic service dialog test Dec 19, 2019
@john-dupuy john-dupuy added customer-case test-automation To be applied on PR's which are automating existing manual cases labels Dec 19, 2019
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about the file_name

@pytest.mark.parametrize("import_data", [DatastoreImport("bz_1364407.zip", "bz_1364407", None)],
ids=["datastore"])
@pytest.mark.parametrize("file_name", ["bz_1364407.yml"], ids=["dynamic_dialog"])
def test_update_dynamic_field_on_refresh(appliance, import_datastore, import_data, file_name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see file_name used in the test case. Why is it needed as a parameter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, right we don't need that. Thanks :)

@john-dupuy john-dupuy changed the title [RFR] Adding new dynamic service dialog test [WIPTEST] Adding new dynamic service dialog test Dec 19, 2019
@niyazRedhat niyazRedhat changed the title [WIPTEST] Adding new dynamic service dialog test [RFR] Adding new dynamic service dialog test Dec 19, 2019
Copy link
Member

@ganeshhubale ganeshhubale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change :)

@ganeshhubale ganeshhubale changed the title [RFR] Adding new dynamic service dialog test [WIPTEST] Adding new dynamic service dialog test Dec 23, 2019
@niyazRedhat niyazRedhat changed the title [WIPTEST] Adding new dynamic service dialog test [RFR] Adding new dynamic service dialog test Dec 30, 2019
@ganeshhubale ganeshhubale changed the title [RFR] Adding new dynamic service dialog test [1LP][RFR] Adding new dynamic service dialog test Dec 30, 2019
@digitronik digitronik merged commit 50fa157 into ManageIQ:master Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-case lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants