-
Notifications
You must be signed in to change notification settings - Fork 165
[1LP][RFR] New Test: Testing managed vms relationships #9788
Conversation
33f1d85
to
60bc436
Compare
60bc436
to
07e5603
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your thoughts on parametrizing the test with configuration dropdown option((Refresh Relationships and Power States, Perform Smartstate Analysis, Extract Running Processes) and the expected flash message?
Let me know what you think?
cfme/infrastructure/datastore.py
Outdated
@@ -448,3 +462,12 @@ class Utilization(CFMENavigateStep): | |||
|
|||
def step(self, *args, **kwargs): | |||
self.prerequisite_view.toolbar.monitoring.item_select("Utilization") | |||
|
|||
|
|||
@navigator.register(Datastore, 'ManagedVMs') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional
Since your navigator class name is same as destination's registered name, you don't need to define it, you could just do -
@navigator.register(Datastore):
class ManagedVMs(CFMENavigateStep):
...
cfme/infrastructure/datastore.py
Outdated
@@ -128,6 +129,19 @@ def is_displayed(self): | |||
) | |||
|
|||
|
|||
class DatastoreManagedVMsView(VmsTemplatesAllView): | |||
""" | |||
This view is used in test_datastore_relationships |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required
I think this could be something like represents All VMs and Templates page for datastores
""" | ||
pass | ||
view = navigate_to(testing_vm.datastore, "ManagedVMs") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really need to provision a VM in order to navigate to its datastore's ManagedVMs view? I understand that this is a part of BZ steps-to-reproduce, but can you not just add a provider, select a datastore, navigate to the ManagedVMs page and test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This is possible:
view = navigate_to(appliance.collections.datastores.all()[0], "ManagedVMs")
- But in this test case, I need to have one VM on which I can perform relationships.
07e5603
to
e34741d
Compare
I detected some fixture changes in commit e34741d The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
Hey @valaparthvi These are three operations we are performing on 1 VM. So IMO we dont need to parametrize and create multiple tests. |
- Testing managed vms relationships
Purpose or Intent
PRT Run
{{ pytest: cfme/tests/cloud_infra_common/test_relationships.py::test_datastore_relationships --use-template-cache -qsvvv --use-provider rhv43 }}