Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] New Test: Testing managed vms relationships #9788

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

ganeshhubale
Copy link
Member

Purpose or Intent

  • Testing managed vms relationships

PRT Run

{{ pytest: cfme/tests/cloud_infra_common/test_relationships.py::test_datastore_relationships --use-template-cache -qsvvv --use-provider rhv43 }}

@ganeshhubale ganeshhubale added the test-automation To be applied on PR's which are automating existing manual cases label Dec 19, 2019
@ganeshhubale ganeshhubale changed the title [WIPTEST] New Test: Testing managed vms relationships [RFR] New Test: Testing managed vms relationships Dec 20, 2019
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are your thoughts on parametrizing the test with configuration dropdown option((Refresh Relationships and Power States, Perform Smartstate Analysis, Extract Running Processes) and the expected flash message?

Let me know what you think?

@@ -448,3 +462,12 @@ class Utilization(CFMENavigateStep):

def step(self, *args, **kwargs):
self.prerequisite_view.toolbar.monitoring.item_select("Utilization")


@navigator.register(Datastore, 'ManagedVMs')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional

Since your navigator class name is same as destination's registered name, you don't need to define it, you could just do -

@navigator.register(Datastore):
class ManagedVMs(CFMENavigateStep):
    ...

@@ -128,6 +129,19 @@ def is_displayed(self):
)


class DatastoreManagedVMsView(VmsTemplatesAllView):
"""
This view is used in test_datastore_relationships
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required
I think this could be something like represents All VMs and Templates page for datastores

"""
pass
view = navigate_to(testing_vm.datastore, "ManagedVMs")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need to provision a VM in order to navigate to its datastore's ManagedVMs view? I understand that this is a part of BZ steps-to-reproduce, but can you not just add a provider, select a datastore, navigate to the ManagedVMs page and test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is possible:

view = navigate_to(appliance.collections.datastores.all()[0], "ManagedVMs")
  • But in this test case, I need to have one VM on which I can perform relationships.

    - Testing managed vms relationships
@dajoRH
Copy link
Contributor

dajoRH commented Dec 23, 2019

I detected some fixture changes in commit e34741d

The local fixture testing_vm is used in the following files:

  • cfme/tests/cloud_infra_common/test_relationships.py
    • test_datastore_relationships

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@valaparthvi valaparthvi changed the title [RFR] New Test: Testing managed vms relationships [1LP][RFR] New Test: Testing managed vms relationships Dec 23, 2019
@ganeshhubale
Copy link
Member Author

What are your thoughts on parametrizing the test with configuration dropdown option((Refresh Relationships and Power States, Perform Smartstate Analysis, Extract Running Processes) and the expected flash message?

Let me know what you think?

Hey @valaparthvi These are three operations we are performing on 1 VM. So IMO we dont need to parametrize and create multiple tests.

@izapolsk izapolsk merged commit 4b8b896 into ManageIQ:master Dec 24, 2019
spusateri pushed a commit to spusateri/integration_tests that referenced this pull request Jan 27, 2020
- Testing managed vms relationships
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants