This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR][NOTEST] Add tests for resolved bugs #9786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarovo
changed the title
john-dupuy
suggested changes
Dec 19, 2019
| Bugzilla: | ||
| 1674055 | ||
| """ | ||
|
|
There was a problem hiding this comment.
Though not functionally necessary, we always have pass in manual case definitions
cfme/tests/test_db_migrate.py
Outdated
| 1. Get CFME VMs of preupdate and target version. | ||
| 2. Make sure the ansible is enabled and create an ansible playbook | ||
| service (for testing the 1735114). | ||
| 2. Turn off the evmserverd processes on both. |
There was a problem hiding this comment.
Small typo, I think this should be step 3.
| caseimportance: critical | ||
| initialEstimate: 1/3h | ||
| startsin: 5.11 | ||
| testSteps: |
There was a problem hiding this comment.
Can you add expectedResults
| caseimportance: high | ||
| casecomponent: Appliance | ||
| initialEstimate: 1/4h | ||
| testSteps: |
There was a problem hiding this comment.
Can you add expectedResults?
john-dupuy
reviewed
Dec 19, 2019
| @@ -137,6 +137,27 @@ def test_update_yum(appliance_preupdate, appliance): | |||
| assert result.output in appliance.version | |||
|
|
|||
|
|
|||
| @pytest.mark.manual() | |||
john-dupuy
changed the title
jarovo
changed the title
jarovo
changed the title
ganeshhubale
suggested changes
Dec 24, 2019
| @@ -384,7 +384,7 @@ def copy_domains(original_request_class, domain): | |||
|
|
|||
|
|
|||
| # Not collected for EC2 in generate_tests above | |||
| @pytest.mark.meta(blockers=[BZ(1713632)]) | |||
| @pytest.mark.meta(automates=[BZ(1713632)]) | |||
| @pytest.mark.parametrize("disks", [1, 2]) | |||
| 1. Settings > Advanced | ||
| 2. Change web_services worker to 1.5.gigabytes or 2.gigabytes | ||
|
|
||
| expectedResults: |
There was a problem hiding this comment.
- Remove extra line(357)
- Also we do not have step 3 then expectedResults should be of step 2
ganeshhubale
changed the title
jarovo
changed the title
jarovo
commented
Jan 2, 2020
| 1. Settings > Advanced | ||
| 2. Change web_services worker to 1.5.gigabytes or 2.gigabytes | ||
|
|
||
| expectedResults: |
added 10 commits
January 2, 2020 17:06
ganeshhubale
changed the title
mshriver
approved these changes
Jan 7, 2020
spusateri
pushed a commit
to spusateri/integration_tests
that referenced
this pull request
Jan 27, 2020
* Add tests for resolved upgrade bugs * Addressed review comments * Add test for BZ 1715633 * Change blocker to automates for BZ 1713632 * Address review comments * Fix problem with test_upgrade_single_sidebyside not accepting db_url param * Add test for 1625788 * Add coverage of 1655794. * Add blocker for BZ 1787350 and coverage for BZ 1658373 * Add automates for BZ 1740515 * Add automates for BZ 1633573
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just another bit to decrease the count of BZs with
qa_tests_coverage?flag.