Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Automate: test_service_refresh_dialog_fields_default_values #9770

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

valaparthvi
Copy link
Contributor

Purpose or Intent

  • Adding tests
    1. Automate: test_service_refresh_dialog_fields_default_values and remove manual test.
  • Enhancement
    1. Add rest_api_entity property to ServiceDialogs.

PRT Run

{{ pytest: cfme/tests/services/test_rest_services.py -k "test_service_refresh_dialog_fields_default_values" --long-running -vvvv }}

@valaparthvi valaparthvi added the test-automation To be applied on PR's which are automating existing manual cases label Dec 16, 2019
@valaparthvi valaparthvi changed the title [WIPTEST] Automate: test_service_refresh_dialog_fields_default_values [RFR] Automate: test_service_refresh_dialog_fields_default_values Dec 17, 2019
@dajoRH dajoRH added the lint-ok label Dec 17, 2019
@ganeshhubale ganeshhubale changed the title [RFR] Automate: test_service_refresh_dialog_fields_default_values [1LP][RFR] Automate: test_service_refresh_dialog_fields_default_values Dec 18, 2019
@test_requirements.rest
@pytest.mark.customer_scenario
@pytest.mark.parametrize("file_name", ["testgear-dialog.yaml"], ids=[''])
def test_service_refresh_dialog_fields_default_values(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional:
Don't you think we need add something in ids?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test name will be like test_service_refresh_dialog_fields_default_values[infra], so I'm okay with not giving it any ID here. Besides, I couldn't think of any good ID name so I kept it empty.

Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks for PR @valaparthvi

@digitronik digitronik merged commit 00fe39a into ManageIQ:master Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-case lint-ok test-automation To be applied on PR's which are automating existing manual cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants