This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] New Test: Verifying dashboard of Remote and Global Appliances #9766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgaikwad
force-pushed
the
test_replication_global_region_dashboard
branch
6 times, most recently
from
9e01805 to
c9bf6db
Compare
dgaikwad
changed the title
dgaikwad
changed the title
dgaikwad
force-pushed
the
test_replication_global_region_dashboard
branch
3 times, most recently
from
2cc3d7a to
40072c6
Compare
dajoRH
changed the title
dgaikwad
force-pushed
the
test_replication_global_region_dashboard
branch
from
40072c6 to
106e59c
Compare
dgaikwad
changed the title
|
@dgaikwad please check the 5.10 failure |
john-dupuy
changed the title
dgaikwad
force-pushed
the
test_replication_global_region_dashboard
branch
2 times, most recently
from
4378328 to
e5a1363
Compare
dgaikwad
changed the title
kedark3
suggested changes
Mar 25, 2020
cfme/tests/test_replication.py
Outdated
| @@ -29,6 +31,16 @@ def create_vm(provider, vm_name): | |||
| return vm | |||
|
|
|||
|
|
|||
| def is_dicts_same(dict1, dict2): | |||
There was a problem hiding this comment.
grammar nitpick, I think it should be are_dicts_same or dicts_compare
cfme/tests/test_replication.py
Outdated
| @@ -329,7 +340,55 @@ def test_replication_global_region_dashboard(): | |||
| 1. | |||
| 2. Dashboard on the Global displays data from the Remote region | |||
| """ | |||
| pass | |||
| remote_app, global_app = setup_replication | |||
| remote_provider = provider_app_crud(RHEVMProvider, remote_app) | |||
There was a problem hiding this comment.
Any reason to choose RHEVMProvider? How about simply InfraProvider or something of that effect, which will be less tied to one type of provider.
dgaikwad
force-pushed
the
test_replication_global_region_dashboard
branch
from
a16bff0 to
760c4e2
Compare
dgaikwad
changed the title
dgaikwad
changed the title
dgaikwad
force-pushed
the
test_replication_global_region_dashboard
branch
from
760c4e2 to
6fa74d0
Compare
dgaikwad
changed the title
dgaikwad
changed the title
|
@kedark3 I have done the requested changes, please look once. |
kedark3
reviewed
Mar 30, 2020
cfme/tests/test_replication.py
Outdated
| data_items = ('EVM: Recently Discovered Hosts', 'EVM: Recently Discovered VMs', | ||
| 'Top Storage Consumers') | ||
|
|
||
| remote_app_data = global_app_data = {} |
There was a problem hiding this comment.
I think this is dangerous. Do you want both of these dicts to store same values?
Example:
>>> remote_app_data = global_app_data = {}
>>> remote_app_data['var1'] = 'val1'
>>> remote_app_data
{'var1': 'val1'}
>>> global_app_data
{'var1': 'val1'}
As you can see if you modify one dict, the other dict also looks the same.
If this is undesired, you may use,
remote_app_data, global_app_data = {},{}
There was a problem hiding this comment.
@kedark3 Thank you for review, will update PR accordingly
dgaikwad
changed the title
dgaikwad
force-pushed
the
test_replication_global_region_dashboard
branch
from
6fa74d0 to
48ece4a
Compare
dgaikwad
force-pushed
the
test_replication_global_region_dashboard
branch
from
48ece4a to
8f55107
Compare
dgaikwad
changed the title
kedark3
approved these changes
Mar 30, 2020
digitronik
approved these changes
Mar 31, 2020
ganeshhubale
pushed a commit
to ganeshhubale/integration_tests
that referenced
this pull request
Jul 21, 2020
…ces (ManageIQ#9766) * New Test: Comparing dashboard of Remote and Global Appliances * changing wait_for call
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
PRT Run
{{pytest: cfme/tests/test_replication.py::test_replication_global_region_dashboard --long-running -v}}