This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] dismiss_alerts closes vmrc related alerts #9764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izapolsk
commented
Dec 12, 2019
| # dismiss_any_alerts() call closed subsequent alerts needed for vmrc | ||
| # below code is needed to fix such issue | ||
| try: | ||
| view.browser.IGNORE_SUBSEQUENT_ALERTS = True |
There was a problem hiding this comment.
would it be worthwhile to replace this try/finally with appropriate context manager ? 🤔
There was a problem hiding this comment.
@izapolsk I think so, it could have uses elsewhere. But I'm okay with that being a separate PR. Up to you if you want to do it here.
john-dupuy
approved these changes
Dec 13, 2019
john-dupuy
changed the title
digitronik
approved these changes
Dec 13, 2019
mshriver
approved these changes
Dec 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it should be disabled during vmrc tests. these changes will be tested by @kedark3 's PR #9703 .