Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Change from_provider to use get_mgmt instead of get_crud #9674

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

jawatts
Copy link
Contributor

@jawatts jawatts commented Nov 25, 2019

No description provided.

@mshriver
Copy link
Member

Looks good, I shouldn't have allowed @john-dupuy to change it to an actual provider object. We didn't hit it until hooks were added to appliance stack push/pop.

Below PR is for wrapping the hook execution and reducing default ssh wait time:
#9675

Also discussing a separate change to where the hook methods are registered, to restrict them to being executed within a pytest context - when we don't have dummy appliance objects, and to reduce the load up time and actions when using appliance objects in local consoles.

Copy link
Member

@mshriver mshriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sat next to you while we talked through the impact, so of course its just absolutely perfect.

@mshriver mshriver changed the title [WIP] Change from_provider to use get_mgmt instead of get_crud [1LP][RFR] Change from_provider to use get_mgmt instead of get_crud Nov 25, 2019
@dajoRH dajoRH removed the WIP label Nov 26, 2019

# TODO Can we remove this?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For vsphere this method is provided by the fixtures

@pytest.fixture(scope="function")
def configure_fleecing(appliance, provider, setup_provider):
vddk_url = get_vddk_url(provider)
provider.setup_hosts_credentials()
appliance.install_vddk(vddk_url=vddk_url)
yield
appliance.uninstall_vddk()
provider.remove_hosts_credentials()
@pytest.fixture(scope="module")
def configure_fleecing_modscope(appliance, provider, setup_provider_modscope):
vddk_url = get_vddk_url(provider)
provider.setup_hosts_credentials()
appliance.install_vddk(vddk_url=vddk_url)
yield
appliance.uninstall_vddk()
provider.remove_hosts_credentials()

Unless we want to keep it as a convenience method for SSA testing. @sbulage do you make use of this method during
your SSA testing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@john-dupuy No I didn't write it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out @john-dupuy, @jawatts and I discussed it and decided because of the larger assumptions and actions in configure_fleecing, we would leave it in place for now.

Copy link
Contributor

@izapolsk izapolsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me . well done !

@izapolsk izapolsk merged commit dc75f35 into ManageIQ:master Nov 26, 2019
spusateri pushed a commit to spusateri/integration_tests that referenced this pull request Jan 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants