Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] removing override=True on provider markers #9644

Merged
merged 1 commit into from
Nov 20, 2019
Merged

[1LP][RFR] removing override=True on provider markers #9644

merged 1 commit into from
Nov 20, 2019

Conversation

mshriver
Copy link
Member

override is unnecessary in pytest 5

@dajoRH dajoRH added the lint-ok label Nov 19, 2019
@mshriver mshriver requested a review from digitronik November 19, 2019 22:10
@izapolsk izapolsk self-requested a review November 20, 2019 11:17
@izapolsk izapolsk self-assigned this Nov 20, 2019
izapolsk
izapolsk approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@izapolsk izapolsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. let's wait for PRT results

@izapolsk izapolsk changed the title [RFR] removing override=True on provider markers [1LP][RFR] removing override=True on provider markers Nov 20, 2019
digitronik
digitronik approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@digitronik digitronik merged commit bd6d9e7 into ManageIQ:master Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@izapolsk izapolsk izapolsk approved these changes

@digitronik digitronik digitronik approved these changes

Assignees

@izapolsk izapolsk

Labels
lint-ok tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshriver @digitronik @izapolsk @dajoRH