Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Fixed zone failing test. #9628

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Conversation

sbulage
Copy link
Contributor

@sbulage sbulage commented Nov 15, 2019

Purpose or Intent

The test is failing with below error:

E       ValueError: not enough values to unpack (expected 1, got 0)

cfme/base/__init__.py:263: ValueError
ValueError
b'not enough values to unpack (expected 1, got 0)'

  • This PR will fix the Zone test (test_zone_add_maxlength)

PRT Run

{{pytest: cfme/tests/configure/test_zones.py::test_zone_add_maxlength -svvvv }}

@sbulage sbulage changed the title [WIPTEST] Fixed zone failing test. [RFR] Fixed zone failing test. Nov 15, 2019
@sbulage
Copy link
Contributor Author

sbulage commented Nov 15, 2019

Here is ipdb output from local test run:

ipdb> zone_res                                                                                                                                                               
<SearchResult for <Collection 'zones' ('Zones')>>
ipdb> zone_res.count                                                                                                                                                         
4
ipdb> zzz = self.appliance.rest_api.collections.zones.find_by(id=self.id)                                                                                                    
ipdb> okaz, = zzz                                                                                                                                                            
*** ValueError: not enough values to unpack (expected 1, got 0)
ipdb> zzz                                                                                                                                                                    
<SearchResult for <Collection 'zones' ('Zones')>>
ipdb> zzz.count                                                                                                                                                              
4
ipdb> zzz = self.appliance.rest_api.collections.zones.find_by(name=self.name)                                                                                                
ipdb> okaz, = zzz                                                                                                                                                            
ipdb> okaz                                                                                                                                                                   
<Entity 'https://<IP>/api/zones/8'>
ipdb>  

Copy link
Contributor

@digitronik digitronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only concern zone name should be unique
@sbulage is it possible to add zone with same name?

@sbulage
Copy link
Contributor Author

sbulage commented Nov 15, 2019

The only concern zone name should be unique
@sbulage is it possible to add zone with same name?

Like id zone name is unique entity

@sbulage sbulage changed the title [RFR] Fixed zone failing test. [1LP][RFR] Fixed zone failing test. Nov 15, 2019
@jawatts jawatts self-assigned this Nov 15, 2019
@jawatts
Copy link
Contributor

jawatts commented Nov 15, 2019

waiting on travis

@jawatts jawatts merged commit 2afe262 into ManageIQ:master Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants