[1LP][RFR] Passed template name as string instead of function

[sshveta]

{{ pytest: cfme/tests/v2v/test_v2v_migrations_single_vcenter.py --use-provider rhv43 --use-provider vsphere67-ims --provider-limit 2 -vvvv --long-running -k test_migration_long_name }}

Made changes to pass template name as string instead of function to fix test failure

         vm_obj = collection.instantiate(
        >           vm_name, source_provider, template_name=template["name"] )
        E       TypeError: 'function' object is not subscriptable`

[john-dupuy]

@sshveta So if I am understanding this right, the issue you're trying to solve here is a pytest issue (pytest-dev/pytest#349). I am partial towards a solution (e.g. for https://github.com/ManageIQ/integration_tests/blob/master/cfme/tests/v2v/test_v2v_migrations.py#L311) that would look something like:

@pytest.mark.parametrize(
    "mapping_data_multiple_vm_obj_single_datastore",
    [
        ["nfs", "nfs", [lambda provider: _get_template(provider, 'win7_template')]],
        ["nfs", "nfs", [lambda provider: _get_template(provider, 'win10_template')]],
        ["nfs", "nfs", [lambda provider: _get_template(provider, 'win2016_template')]],
        ["nfs", "nfs", [lambda provider: _get_template(provider, 'rhel69_template')]],
        ["nfs", "nfs", [lambda provider: _get_template(provider, 'win2012_template')]],
        ["nfs", "nfs", [lambda provider: _get_template(provider, 'ubuntu16_template')]],
    ],
    indirect=True,
)

This way you can still get the template name through template.name. @mshriver @jawatts @izapolsk thoughts on an approach like this one? Is there a better approach to parametrize these tests based on fixtures?

[john-dupuy]

Nice use of the enum class! Some minor questions and suggestion, please take a look.

[dajoRH]

I detected some fixture changes in commit c6dd476

Show fixtures

The global fixture mapping_data_vm_obj_mini is used in the following files:

• cfme/tests/v2v/test_post_migrations.py
  • test_migration_post_attribute
• cfme/tests/v2v/test_v2v_cancel_migrations.py
  • cancel_migration_plan
• cfme/tests/v2v/test_v2v_migrations_single_vcenter.py
• cfme/tests/v2v/test_v2v_migrations_ui.py
  • test_duplicate_plan_name
  • test_duplicate_mapping_name
• cfme/tests/v2v/test_v2v_schedule_migrations.py
  • test_schedule_migration

The global fixture mapping_data_multiple_vm_obj_single_datastore is used in the following files:

• cfme/tests/v2v/test_migration_throttling.py
• cfme/tests/v2v/test_v2v_cancel_migrations.py
• cfme/tests/v2v/test_v2v_migrations.py
• cfme/tests/v2v/test_v2v_migrations_single_vcenter.py
• cfme/tests/v2v/test_v2v_smoke.py

The global fixture mapping_data_single_datastore was changed, but I didn't find where it's used.
The global fixture mapping_data_single_network was changed, but I didn't find where it's used.
The global fixture mapping_data_dual_vm_obj_dual_datastore is used in the following files:

• cfme/tests/v2v/test_v2v_migrations.py

The global fixture mapping_data_vm_obj_dual_nics is used in the following files:

• cfme/tests/v2v/test_v2v_migrations.py

The global fixture mapping_data_vm_obj_single_datastore is used in the following files:

• cfme/tests/v2v/test_v2v_ansible.py
• cfme/tests/v2v/test_v2v_cancel_migrations.py
• cfme/tests/v2v/test_v2v_migrations.py
• cfme/tests/v2v/test_v2v_migrations_single_vcenter.py
• cfme/tests/v2v/test_v2v_migrations_ui.py

The global fixture mapping_data_vm_obj_single_network is used in the following files:

• cfme/tests/v2v/test_v2v_migrations.py

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

[mshriver]

Looking solid to me, thanks for your patience @sshveta! Let's wait on some PRT results and be sure we want the resulting test case ID's before all the polarion churn.