Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] - Updating assignee of automate FA - Automate #10030

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

dgaikwad
Copy link
Contributor

@dgaikwad dgaikwad commented Apr 1, 2020

Purpose or Intent

PRT Run

@dajoRH dajoRH added the lint-ok label Apr 1, 2020
@dajoRH
Copy link
Contributor

dajoRH commented Apr 1, 2020

I detected some fixture changes in commit 651153fc4481518644c44e150d0341d40d3b2872

The local fixture cls is used in the following files:

  • cfme/tests/automate/test_vmware_methods.py

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@ganeshhubale ganeshhubale added the test-cleanup Test removal, collection changes, re-organization label Apr 1, 2020
@@ -29,6 +29,7 @@ def cls(domain):
original_class = domain.parent\
.instantiate(name='ManageIQ')\
.namespaces.instantiate(name='System')\
.namespaces.instantiate(name='System')\
.classes.instantiate(name='Request')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you resolving any issue here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mistakenly added the extra line, now PR is updated please review

@dgaikwad dgaikwad force-pushed the automate_fa_reassignment branch from 651153f to 5539ac0 Compare April 1, 2020 12:01
@jarovo jarovo changed the title [RFR] - Updating assignee of automate FA [1LP][RFR] - Updating assignee of automate FA Apr 2, 2020
@dgaikwad dgaikwad force-pushed the automate_fa_reassignment branch from 5539ac0 to 4bda6a6 Compare April 3, 2020 05:11
@mshriver mshriver self-assigned this Apr 8, 2020
@mshriver mshriver merged commit 48464ec into ManageIQ:master Apr 8, 2020
@dgaikwad dgaikwad changed the title [1LP][RFR] - Updating assignee of automate FA [1LP][RFR] - Updating assignee of automate FA - Automate Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lint-ok test-cleanup Test removal, collection changes, re-organization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants