[RFR] Update pre-commit hooks rev

[digitronik]

Purpose or Intent

• These are new changes related to pyupgrade in fever of PR
  [RFR] Apply pyupgrade #10027

• Mostly related to file read mode as its default.

NOTE: Changes are related to pre-commit run :D (not maual)

PRT Run

[RonnyPfannschmidt]

all of those fauxfactory.gen_$name that moved into f strings might help readability if from fauxfactory import gen_$name as faux_name was used
but that convention also has some downs, it may not be worth it

[valaparthvi]

Suggested change

	rand_filename = f"/tmp/db.backup_{fauxfactory.gen_alphanumeric()}"
	rand_filename = fauxfactory.gen_alphanumeric(start="/tmp/db.backup_", length=20)

[valaparthvi]

If you're going to implement this then same change is required everywhere in this PR.

[digitronik]

@valaparthvi this change more related to pyupgrade. we are adding this in support of last changes. We will do in another PR; I'm avoiding this as inderectly fauxfactory also using .format

[digitronik]

all of those fauxfactory.gen_$name that moved into f strings might help readability if from fauxfactory import gen_$name as faux_name was used

yup

but that convention also has some downs, it may not be worth it

I added prefix like start in fauxfactory to avoid .format (mainly py2.7) support :D. But now we moved to py3.7 so that f-string doing this work.

I agreed with you... need to think about more readability.

[ganeshhubale]

LGTM :)

[dajoRH]

I detected some fixture changes in commit dcb6aee

Show fixtures

The global fixture candu_db_restore is used in the following files:

• cfme/tests/candu/test_graph_groupbytag.py
  • test_tagwise

The global fixture depot_machine_ipv4_and_ipv6 is used in the following files:

• cfme/tests/configure/test_log_depot_operation.py
  • test_log_collection_over_ipv6

The global fixture import_dialog is used in the following files:

• cfme/tests/automate/test_service_automate.py
• cfme/tests/automate/test_service_dialog.py
  • custom_button
• cfme/tests/services/test_dialog_element_in_catalog.py
  • test_request_details_page_tagcontrol_field
  • test_save_dynamic_multi_drop_down_dialog
• cfme/tests/services/test_dynamicdd_dialogelement.py
  • test_dynamic_submit_cancel_button_service
• cfme/tests/services/test_myservice.py
  • test_load_service_with_button
• cfme/tests/services/test_rest_services.py
• cfme/tests/services/test_service_customer_bz.py
  • test_edit_import_dialog

The local fixture provider_credentials is used in the following files:

• cfme/tests/ansible/test_embedded_ansible_services.py

The local fixture default_alerts is used in the following files:

• cfme/tests/control/test_default_alerts.py
  • test_default_alerts

The local fixture vm_ownership is used in the following files:

• cfme/tests/intelligence/chargeback/test_chargeback_long_term_rates.py
  • resource_usage
  • chargeback_report_custom

The local fixture db_restore is used in the following files:

• cfme/tests/optimize/test_bottlenecks.py
  • test_bottlenecks_report_event_groups
  • test_bottlenecks_report_show_host_events
  • test_bottlenecks_report_time_zone
  • test_bottlenecks_summary_event_groups
  • test_bottlenecks_summary_show_host_events
  • test_bottlenecks_summary_time_zone

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃