This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Fixing jenkins failure #10012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnadeem92
force-pushed
the
fix_test_csv_security_group_flavor_test
branch
from
04416e0 to
de9cbb9
Compare
valaparthvi
suggested changes
Mar 24, 2020
| table_hover=True, security_group=True) | ||
| assert not DeepDiff(actual_attributes, expected_attributes) | ||
|
|
||
| soft_assert(expected_attributes["security_group"] == security_group) |
There was a problem hiding this comment.
Why are you using soft_assert here instead of assert?
From what I understand, you only use soft_assert when you have to assert more than 1 statement in a single test to pass and you don't want your test to break in the middle if any one of the assert statements fails.
There was a problem hiding this comment.
down the line we have one more assert which is why i have used soft_assert above.
valaparthvi
added
test-cleanup
sshveta
approved these changes
Mar 24, 2020
Signed-off-by: mnadeem92 <[email protected]>
mnadeem92
force-pushed
the
fix_test_csv_security_group_flavor_test
branch
from
de9cbb9 to
0ac71c4
Compare
valaparthvi
approved these changes
Mar 25, 2020
valaparthvi
changed the title
digitronik
approved these changes
Mar 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mnadeem92 [email protected]
{{ pytest: cfme/tests/v2v/test_csv_import.py -k "test_csv_security_group_flavor" --use-provider osp13-ims --use-provider vsphere67-ims --provider-limit 2 -v }}