Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][RFR] Add test_appliance_reporting_role for BZ 1629945 #10006

Merged
merged 1 commit into from
Mar 26, 2020
Merged

[1LP][RFR] Add test_appliance_reporting_role for BZ 1629945 #10006

merged 1 commit into from
Mar 26, 2020

Conversation

tpapaioa
Copy link
Contributor

@tpapaioa tpapaioa commented Mar 20, 2020

This PR adds BZ test coverage for:

Bug 1629945 - Reports do not run when submitted through a UI which does not have reporting role on.
https://bugzilla.redhat.com/show_bug.cgi?id=1629945

The new test, test_appliance_reporting_role, configures a primary and secondary appliance pair, disables the Reporting role and then queues a report from the primary appliance's web UI, and verifies that the report is run successfully.

{{ pytest: -v --long-running -k test_appliance_reporting_role cfme/tests/distributed/test_appliance_replication.py }}

@dajoRH
Copy link
Contributor

dajoRH commented Mar 20, 2020

I detected some fixture changes in commit b8d6c5aae6794e70ae59a1a26beeae9f8c4c6aa1

The global fixture distributed_appliances is used in the following files:

  • cfme/tests/distributed/test_appliance_replication.py
    • test_external_database_appliance
    • test_appliance_httpd_roles
    • test_appliance_reporting_role

The global fixture replicated_appliances is used in the following files:

  • cfme/tests/distributed/test_appliance_replication.py
    • test_appliance_replicate_between_regions
    • test_appliance_replicate_database_disconnection
    • test_appliance_replicate_database_disconnection_with_backlog
    • test_replication_connect_to_vm_in_region
    • test_appliance_replicate_zones
    • test_appliance_replicate_remote_down

The global fixture replicated_appliances_preupdate was changed, but I didn't find where it's used.
The global fixture replicated_appliances_with_providers is used in the following files:

  • cfme/tests/cli/test_appliance_console_db_restore.py

The global fixture replicated_appliances_preupdate_with_providers is used in the following files:

  • cfme/tests/cli/test_appliance_update.py
    • test_update_replicated_webui

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@dajoRH dajoRH added lint-ok and removed needs-lint labels Mar 26, 2020
@tpapaioa tpapaioa changed the title [WIPTEST] Worker appliance reporting role [RFR] Add test_appliance_reporting_role for BZ 1629945 Mar 26, 2020
Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this PR @tpapaioa

@john-dupuy john-dupuy changed the title [RFR] Add test_appliance_reporting_role for BZ 1629945 [1LP][RFR] Add test_appliance_reporting_role for BZ 1629945 Mar 26, 2020
@mshriver mshriver merged commit 9435d77 into ManageIQ:master Mar 26, 2020
@tpapaioa tpapaioa deleted the worker_appliance_reporting_role branch March 26, 2020 23:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants