From 536cad335219e5aa39bbd093f895fb76d6551281 Mon Sep 17 00:00:00 2001
From: Jaroslav Henner <jhenner@redhat.com>
Date: Tue, 10 Dec 2019 19:44:58 +0100
Subject: [PATCH] [RFR] Changes to resolve the customer qa test coverage
 (#9751)

* Add test_provision_approval_deny

* Add test_provision_service_dialog_details manual test.

* Add automates for scheduled backup BZ#1678223

* Make test_upgrade_multi_replication_inplace high prio

There was a customer bug for this test.
The coverage marker was set to a clone of the original bug. I think this
is not correct. I set it to the original bug.
---
 .../cloud_infra_common/test_provisioning.py   | 49 +++++++++++++++++++
 .../configure/test_db_backup_schedule.py      |  1 +
 cfme/tests/test_db_migrate_manual.py          |  4 +-
 3 files changed, 52 insertions(+), 2 deletions(-)

diff --git a/cfme/tests/cloud_infra_common/test_provisioning.py b/cfme/tests/cloud_infra_common/test_provisioning.py
index fc842a024c..eea0a470a2 100644
--- a/cfme/tests/cloud_infra_common/test_provisioning.py
+++ b/cfme/tests/cloud_infra_common/test_provisioning.py
@@ -124,6 +124,28 @@ def test_gce_preemptible_provision(appliance, provider, instance_args, soft_asse
     soft_assert(instance.exists_on_provider, "Instance wasn't provisioned successfully")
 
 
+@pytest.mark.manual
+@pytest.mark.meta(coverage=[1676910])
+def test_provision_approval_deny():
+    """ Test whether the approver can deny the request.
+
+    Prerequisities:
+        * A provider that can provision.
+
+    Steps:
+        * Create a provisioning request that does not get automatically approved (eg. ``num_vms``
+            bigger than 1)
+        * Deny the created request
+
+    Polarion:
+        assignee: jhenner
+        caseimportance: high
+        casecomponent: Provisioning
+        initialEstimate: 1/3h
+    """
+    pass
+
+
 @pytest.mark.rhv2
 @pytest.mark.meta(automates=[1472844])
 @pytest.mark.parametrize("edit", [True, False], ids=["edit", "approve"])
@@ -673,3 +695,30 @@ def test_provision_from_template_from_global_region(setup_multi_region_cluster,
         initialEstimate: 1/10h
     """
     assert provisioned_instance.exists_on_provider, "Instance wasn't provisioned successfully"
+
+
+@pytest.mark.manual
+@pytest.mark.meta(coverage=[1670327])
+def test_provision_service_dialog_details():
+    """ Test whether the details of provision request can be displayed.
+
+    Prerequisities:
+        * A Local/Global replicated CFMEs.
+        * A provider that can provision.
+
+    Steps:
+        * Add repository and create a service catalog with a dialog at remote region
+        * Try provisioning the catalog from Global Region
+        * You can see the dialog details in Services -> Requests page
+
+    Expected results:
+        The dialog details at Services -> Requests should be displayed when
+        ordering the catalog from the Global Region
+
+    Polarion:
+        assignee: jhenner
+        caseimportance: medium
+        casecomponent: Provisioning
+        initialEstimate: 1/6h
+    """
+    pass
diff --git a/cfme/tests/configure/test_db_backup_schedule.py b/cfme/tests/configure/test_db_backup_schedule.py
index caedc86790..0d1119cec8 100644
--- a/cfme/tests/configure/test_db_backup_schedule.py
+++ b/cfme/tests/configure/test_db_backup_schedule.py
@@ -135,6 +135,7 @@ def get_full_path_to_file(path_on_host, schedule_name):
 
 
 @pytest.mark.tier(3)
+@pytest.mark.meta(automates=[1678223])
 def test_db_backup_schedule(request, db_backup_data, depot_machine_ip, appliance):
     """ Test scheduled one-type backup on given machines using smb/nfs
 
diff --git a/cfme/tests/test_db_migrate_manual.py b/cfme/tests/test_db_migrate_manual.py
index a705505580..d4f549e2b6 100644
--- a/cfme/tests/test_db_migrate_manual.py
+++ b/cfme/tests/test_db_migrate_manual.py
@@ -340,7 +340,7 @@ def test_rh_registration_proxy_crud():
 
 @pytest.mark.manual
 @pytest.mark.tier(2)
-@pytest.mark.meta(coverage=[1722540])
+@pytest.mark.meta(coverage=[1721596])
 def test_upgrade_multi_replication_inplace():
     """
     test_upgrade_multi_replication_inplace
@@ -348,7 +348,7 @@ def test_upgrade_multi_replication_inplace():
     Polarion:
         assignee: jhenner
         casecomponent: Configuration
-        caseimportance: medium
+        caseimportance: high
         initialEstimate: 1h
         setup: 2 appliances:
                - Appliance A: Replication Global, region 0