You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Most times, params are needed (because sanitizing them is the point of using AwesomeSpawn, otherwise you'd probably just use backticks). But that params key is clunky.
Additionally, the params key is not passed to AwesomeSpawn.build_command_line
AwesomeSpawn.build_command_line("ls",[:a,:l])# => "ls -a -l"
As such, I propose we drop the params key altogether, and make it part of the "command" portion via Array or Hash. So, I could see one or all of
I kind of like the first one, and the second one is just an associative array version of the first (i.e. it's the same as .to_a), so it's straightfoward to implement.
Then, we should make build_command_line have the exact same interface.
The text was updated successfully, but these errors were encountered:
A typical command is currently:
Most times, params are needed (because sanitizing them is the point of using AwesomeSpawn, otherwise you'd probably just use backticks). But that params key is clunky.
Additionally, the params key is not passed to AwesomeSpawn.build_command_line
As such, I propose we drop the params key altogether, and make it part of the "command" portion via Array or Hash. So, I could see one or all of
I kind of like the first one, and the second one is just an associative array version of the first (i.e. it's the same as
.to_a
), so it's straightfoward to implement.Then, we should make
build_command_line
have the exact same interface.The text was updated successfully, but these errors were encountered: