Warning and backwards compatibility

[amno1]

Hello and thanks for the Beacon; it has been a beacon of my cursor finding for many years!

However, over the years, Emacs has changed, and when compiled nowadays, there are few warnings. It is not a big deal, everything still works of course, but I like when things compile cleanly :).

They are all trivial to fix, but that might make Beacon incompatible with older Emacses.

So my question is: do you wish a PR with fixes (doc warning, minor-mode positional args, focus hooks) or do you plan to fix them yourself? I think they should all work back to v27, but I am not 100%, haven't actually tried in anything but current master (v29).

[Malabarba]

Hi Arhur,

No I wasn't planning on addressing them myself. :-)
Feel free to create a PR!

[amno1]

Ok, cool, thnks.

I made a PR, see if it works. I am not sure with how old Emacses you would like to keep compatibility. The PR could be made compatible with 24.4, but I am not sure if there is point. Package-lint says 25.1 is OK.

I also run checkdoc and package-lint on it and fixed some extra trivialities, when I was already at it. Of course, feel free to rework it if needed.